-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Footnote patches in 4.20.xx #55
Comments
I'm most likely going to remove it, then (I'm didn't originally create that one, I don't use it, and I'm not familiar enough with it). |
Hmm, as I remember, you created the footnote font-family patch when I asked you whether it could be done. You were the one who told me that it was "hidden" in the CSS stream containing |
Oops, fat fingers! Didn't mean to close it. ETA: I should have also said that if you don't want to update it that's OK with me. But, without some guidance from you, I will not be able to do much about updating the unofficial footnote font-size patch, other than what I've already said above. |
I'd have to look at my notes. I honestly don't remember doing it, but what you said rings a bell for me. Sorry about my forgetfulness. |
OK, I guess I was thinking of a different footnote patch earlier which wasn't mine. I just had a look at this, and it does seem to have changed. Your new patch is correct, as confirmed by: My patch wasn't intended to do anything other than change the font-family, so it doesn't seem like it is necessary anymore (the font is now serif by default). I'm going to remove this patch, but if anyone ends up wanting to change the font-size, I'll include the one you posted above. |
I missed your response until just now. Thanks for looking. My Assembler is non-existent but your code snippet I've still no idea where these font-size constants are being set, though. Does that snippet provide any clues to you? I investigated by quick&dirty patching a few occurrences of Daylight/font-size:42px in the nickel CSS but none of them did me any good. |
PS. Nevermind, I found out I could replace Georgia with a customized font of the same name instead. Here is my original comment: |
@geek1011
I don't think your official nickel patch
Change pop-up footnote font-family
is doing anything anymore. If the aim is to make sure pop-up footnotes use Georgia (rather than Avenir) then I think the patch can be removed. However, if the aim is to give font-family full customisation to the user then I think a new pop-up footnote code investigation is needed. Second opinions welcome 😄As a follow on ... I've previously posted an unofficial patch to control font-size of footnote text. This no longer works either. As with many parts of the GUI (IMO) default footnote font-size on a KA1/Forma is huge. Other models seem OK.
The only workaround I've found so far is a new libnickel patch, but it's not ideal because it doesn't allow a different font-size per model.
If we knew where the
%1px
value was being read from it might be a help.The text was updated successfully, but these errors were encountered: