Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostgreSQL 16 support #215

Closed
devrimgunduz opened this issue Jun 6, 2023 · 11 comments · Fixed by #216
Closed

PostgreSQL 16 support #215

devrimgunduz opened this issue Jun 6, 2023 · 11 comments · Fixed by #216
Assignees
Labels

Comments

@devrimgunduz
Copy link

Hi,

PostgreSQL 16 Beta 1 is out. What are the plans for v16 support?

Regards, Devrim

@gbartolini
Copy link

gbartolini commented Jun 7, 2023

Related to #208

Unfortunately, while I was able to make it compile on PG16, I suspect there are changes to be done in the source code to reflect the "Rework query relation permission checking" patch.

Postgres crashes at start time.

@dwsteele dwsteele self-assigned this Jun 7, 2023
@dwsteele
Copy link
Contributor

dwsteele commented Jun 7, 2023

I started with Gabrielle's patch and now have something that works on PG16. There were a lot of changes this time around: master...dev-pg16-ci

However, there is still a regression in view logging that I have not resolved yet. I'm not sure I want to release a beta until I have figured this out: master...dev-pg16-ci#diff-db4bb73982787fa1d07d4c9d80bc54028b8d2a52b80806f1352a42c42f00eaaaL199

It may be that this is a side effect of the RTEPermissionInfo refactor, but I have not had time to dig into it. Any thoughts on this much appreciated!

@dwsteele
Copy link
Contributor

dwsteele commented Jun 9, 2023

I have opened #216 with all the changes required for PG16, but this is going to need some serious review before I can commit it. So, please review/test!

@dwsteele dwsteele linked a pull request Jun 9, 2023 that will close this issue
@dwsteele
Copy link
Contributor

The issue with the views has been resolved but we'll wait for Postgres beta 2 before we release our beta. https://www.postgresql.org/message-id/flat/0c8b49f1-33e1-a4db-a090-f3b6654b8a1e%40pgmasters.net#1e3742984f8629b8e15918a6e267025b.

@gbartolini
Copy link

This is great. Thanks so much!

@sxd
Copy link

sxd commented Jul 18, 2023

hi @dwsteele

The Postgresql beta 2 was released on June 29, when can we expect to have this beta?

Regards,

@dwsteele
Copy link
Contributor

dwsteele commented Aug 3, 2023

The 16beta1 tag has been created. Note that versioning has changed for this release, rather than 1.X the version will reflect the version of PostgreSQL that is supported.

@dwsteele dwsteele closed this as completed Aug 3, 2023
@devrimgunduz
Copy link
Author

Thanks for the version change! Really appreciated.

@gbartolini
Copy link

Indeed, thanks a lot for making this happen!

@pere3
Copy link

pere3 commented Mar 19, 2024

The 16beta1 tag has been created. Note that versioning has changed for this release, rather than 1.X the version will reflect the version of PostgreSQL that is supported.

that's kinda breaks a lot of CI-processes, which were adapted for previously used versioning system 😞

@dwsteele
Copy link
Contributor

Sorry about that -- we ran this by some packagers before making the change and the response was very positive. In any case, the time to bring this up would have been last August. I can't see us reverting the change now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants