Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

help fails if configuration is faulty #2211

Open
mbanck opened this issue Oct 25, 2023 · 1 comment
Open

help fails if configuration is faulty #2211

mbanck opened this issue Oct 25, 2023 · 1 comment

Comments

@mbanck
Copy link

mbanck commented Oct 25, 2023

Please provide the following information when submitting an issue (feature requests or general comments can skip this):

  1. pgBackRest version: 2.48

  2. PostgreSQL version: n/a

  3. Operating system/version - if you have more than one server (for example, a database server, a repository host server, one or more standbys), please specify each: Debian stable

  4. Did you install pgBackRest from source or from a package?

package

  1. Describe the issue:
root@host:~# pgbackrest help backup
ERROR: [031]: configuration file contains duplicate options ('repo-path', 'repo1-path') in section '[global]'

I think help should always work, even if the configuration is faulty, but maybe that is too difficult to achieve with how the pgBackRest CLI is implemented.

@dwsteele dwsteele self-assigned this Oct 26, 2023
@dwsteele
Copy link
Member

Well, yeah, that's pretty terrible.

But you are correct that help relies on the configuration module to provide lists of options per command, defaults, current settings, etc.

Even so, there should be some sort of fallback that gives basic help even when the configuration is broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants