Terminology

[mathiasbynens]

Hey, glad to see you packaged this into a module!

Just a small suggestion: the terminology “valid literal” and “valid string literal” is a bit off. E.g.

Check if input is a valid javascript string literal or needs quoting

A string literal is by quoted already, by definition.

Instead, this code checks for valid identifier names or numeric literals as only those can be used as property names in object literals.

[…] quotes can only be omitted if the property name is a numeric literal or a valid identifier name […]

You may want to correct things like this in the README:

Check if input is a valid javascript string literal or needs quoting

And arguably the repository name could be changed as well.

[pgilad]

Hey thanks for the feedback! I really appreciate it..

Yeah this could definitely use terminology changes. I'll get on it

[pgilad]

👍

[mathiasbynens]

👍

Don’t forget to update the repo description:

[pgilad]

Done.. Thanks for the tips, and the awesome research & code... 😄