Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

h11_max_incomplete_size marked as HTTP/2 in documentation #58

Closed
touilleMan opened this issue Jun 10, 2022 · 2 comments · Fixed by #80
Closed

h11_max_incomplete_size marked as HTTP/2 in documentation #58

touilleMan opened this issue Jun 10, 2022 · 2 comments · Fixed by #80

Comments

@touilleMan
Copy link
Contributor

In the documentation:
image

However h11_max_incomplete_size is used in h11 (so HTTP 1.1 support):

hypercorn/src/hypercorn/protocol/h11.py

Line 96 in 8cef567

h11.SERVER, max_incomplete_event_size=self.config.h11_max_incomplete_size

@touilleMan
Copy link
Contributor Author

Also it would be good to document the default values for the various limits in the documentation, cf.

hypercorn/src/hypercorn/config.py

Lines 75 to 78 in 8cef567

h11_max_incomplete_size = 16 * 1024 * BYTES
h2_max_concurrent_streams = 100
h2_max_header_list_size = 2**16
h2_max_inbound_frame_size = 2**14 * OCTETS

Would you accept a PR on this ?

@pgjones
Copy link
Owner

pgjones commented Aug 28, 2022

I'd very much welcome PRs on these

@touilleMan touilleMan mentioned this issue Sep 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document default config values in configuration.rst touilleMan/hypercorn
2 participants
@pgjones @touilleMan