Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension init types do not match docs or code #15

Closed
aenglander opened this issue Jan 21, 2024 · 1 comment
Closed

Extension init types do not match docs or code #15

aenglander opened this issue Jan 21, 2024 · 1 comment

Comments

@aenglander
Copy link
Contributor

When specifying either cookie_http_only or cookie_secure in the init of QuartAuth as below:

from quart_auth import QuartAuth

quart_auth = QuartAuth(
    cookie_http_only=True,
    cookie_secure=True,
)

mypy will raise errors:

mypy scratch.py
scratch.py:4: error: Argument "cookie_http_only" to "QuartAuth" has incompatible type "bool"; expected "str | None"  [arg-type]
scratch.py:5: error: Argument "cookie_secure" to "QuartAuth" has incompatible type "bool"; expected "str | None"  [arg-type]
Found 2 errors in 1 file (checked 1 source file)
@aenglander aenglander mentioned this issue Jan 21, 2024
Closed
@pgjones
Copy link
Owner

pgjones commented May 18, 2024

Fixed in 8c3bdc4

@pgjones pgjones closed this as completed May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update extension init typing to match docs and code aenglander/quart-auth
2 participants
@aenglander @pgjones