Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No real documentation on creating continuous Bayesian networks #39

Open
bramson opened this issue Mar 10, 2020 · 3 comments
Open

No real documentation on creating continuous Bayesian networks #39

bramson opened this issue Mar 10, 2020 · 3 comments

Comments

@bramson
Copy link

bramson commented Mar 10, 2020

I've read through the documentation and notebooks for Continuous Factors several times, but there is still a big gap between what is written there and what I need to know to create an actual Bayesian network using continuous factors.

It would be great (and I would say essential if you want this library to be used by people) to provide working examples of creating a actual simple Bayesian network including continuous factors in the documentation and/or notebooks. But not overly simple examples so that they can't be extrapolated to real problems.

Your explanations and examples of setting up the conditional probability tables were clear and sufficient. So, essentially, just do what was done for the discrete cases, but for the continuous factors.

Specifically, I can't figure out some basic setup operations. If I have a node C with two continuous inputs A and B, how do I set the parameters of the distribution of C as a function of the distributions A and B. Perhaps as a step in explaining this, you can first explain how to setup the continuous node C where A and B are discrete, then expand that to cover the case where A is discrete and B is continuous, then where they are both continuous.

Also, the LaTeX equations in the documents don't show correctly, they are filled with "unknown character" errors.

@ankurankan
Copy link
Member

@bramson Thanks for the feedback. The continuous variable documentation is not clear because the continuous variable features are not yet fully integrated in the package. I have created an issue to add a list of supported features in the documentation so that it's not confusing for the users.

@giri-fiu
Copy link

Have the continuous variable features been integrated into the "pgmpy" package? If so, is there new documentation? If not, are there alternative packages you can suggest?

@ankurankan
Copy link
Member

@giri-fiu There is partial support (structure learning and some causal inference features) for continuous variables in pgmpy now: pgmpy.org. Continuous Factors are still not supported. Depending on what features you are looking for, you can check out https://github.com/jmschrei/pomegranate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants