Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When stopping/starting, the remaining sound in the queue plays before the new song start. #12

Closed
pgregory opened this issue Dec 7, 2016 · 3 comments
Labels

Comments

@pgregory
Copy link
Owner

pgregory commented Dec 7, 2016

Need to find a way to flush the sound buffers when stopping playback and starting a new, or replaying the current song from the start.

@a1k0n
Copy link

a1k0n commented Dec 7, 2016

Yeah, the jsxm pause functionality just disconnects the ScriptProcessorNode from the output entirely, which leaves everything in its buffer... instead, you'll have to pause the pattern row processing but leave the audio engine running, and silence all the channels or something.

jsxm's sequence playback and audio engine are a bit tightly coupled, and you'll have to break that for an interactive editor if you want to use it...

@a1k0n
Copy link

a1k0n commented Dec 13, 2016

I think you can close this, except now, you need to add a "stop" button which releases notes in all channels. :)

@pgregory
Copy link
Owner Author

This specific issue is no longer relevant, the player has changes significantly since reporting this. There are other issues that capture any remaining problems. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants