Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/rest/trait/{trait_id} does not seem to include a child_traits element #209

Closed
ramiromagno opened this issue Sep 27, 2021 · 2 comments · Fixed by #210
Closed

/rest/trait/{trait_id} does not seem to include a child_traits element #209

ramiromagno opened this issue Sep 27, 2021 · 2 comments · Fixed by #210

Comments

@ramiromagno
Copy link

ramiromagno commented Sep 27, 2021

The endpoint /rest/trait/{trait_id} should return a EFOTrait_OntologyChild element as per the schema. This object type should include a child_traits element at the top level.

I have just played with the examples here: https://www.pgscatalog.org/rest/#/Trait%20endpoints/getTrait but it seems that the element child_traits is never included in the response object, resembling the response of type EFOTrait_Ontology.

BTW: Would you consider making both endpoints return objects of type EFOTrait_OntologyChild?

@ens-lgil ens-lgil linked a pull request Sep 27, 2021 that will close this issue
@ens-lgil
Copy link
Member

Dear @ramiromagno,

Thank you for spotting this issue.
This was a due to commented code pushed during a big commit. I reverted it and deployed the fix, so it should work now.

Thanks again!

Best regards,
Laurent

@ramiromagno
Copy link
Author

Thank you for such a quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants