Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query string not outputed by recorder when output_objects: false #242

Closed
marcboscher opened this issue Nov 3, 2014 · 4 comments
Closed

Comments

@marcboscher
Copy link

This is the same problem as in #130 and #202 but only when setting output_objects: false

Basically the following fix must also be applied to the method generateRequestAndResponse:
options.path = req.path;

See 9c16f2e#diff-10

@trshafer
Copy link
Contributor

+1. Also experiencing this.

@pgte
Copy link
Member

pgte commented Oct 12, 2015

Glad to accept PR with this fixed.

@stale
Copy link

stale bot commented Sep 17, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We try to do our best, but nock is maintained by volunteers and there is only so much we can do at a time. Thank you for your contributions.

@stale stale bot added the stale label Sep 17, 2018
@stale stale bot closed this as completed Sep 24, 2018
@lock
Copy link

lock bot commented Oct 8, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Oct 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants