reply with an asynchroneous response.

[Natim]

I am trying to do the following:

  function readAws() {
    return nock('https://s3.amazonaws.com')
      .filteringPath(function filter(_path) {
        id = _path.replace('/' + bucket + '/', '');
        return _path.replace(id, 'XXX');
      })
      .get(u)
      .reply(200, function() {
        console.log(arguments);
        var s = through();
        s.setEncoding = function() {};
        console.log("ID", id);
        local.read(id, function(err, data) {
          if (err) throw err;
          s.queue(encode(data));
          s.end();
        });
        return s;
      });
  }

The aim is to basically use the local file storage api to mock the remote aws one.
But by the time I am reading the buffer, it is still empty.

The good call would be to be able to get a callback on the reply callback function in order to tell nock when it is finished.

[Natim]

Similar questions:

• http://stackoverflow.com/questions/25697093/node-js-nock-and-nedb-reply-gets-executed-before-the-call-back-finishes
• http://stackoverflow.com/questions/25684307/node-js-module-nock-reply-with-a-callback-doesnt-work

[pgte]

yeah, we don't support an asynchronous handler. I would love a PR with that :).

Basically nock would have to check function arguments length to see if the function would or not be asynchronous and provide a callback when it is.

[Natim]

Yes it seems that mocha is doing a similar thing with the done parameter.

[Natim]

The code to add stand apparently there: https://github.com/pgte/nock/blob/master/lib/request_overrider.js#L264-L268

[Natim]

@pgte You asked for a PR, here is my proposal.

r? @n1k0

[Natim]

After this line I didn't touch the code just indent it because of the new function definition.

[pgte]

I think that the callback should be using the standard callback pattern: error-first, so that it can be easily composed with other I/O.

This allows stuff like:

.reply(function(cb) {
  fs.readFile(file, cb);
});

or even better:

.reply(fs.readFile.bind(fs, file));

Then the answer comes: what happens when there is an error happens? I propose that it's just thrown so that the test stops.

[Natim]

Yes good point, I was thinking about it and then I realize that there should not be errors at that point but you've made your point, I will change that.

[Natim]

Updated with @pgte comments.

[pgte]

@Natim thanks!

Landed on v1.2.0

[almet]

Awesome, thanks @pgte.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!