Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix key when interceptor path is specified with callback #474

Merged
merged 1 commit into from
Feb 15, 2016

Conversation

owiber
Copy link

@owiber owiber commented Feb 11, 2016

I'm not sure if this is the best fix for the issue, but this fixes #473.

Also not sure if I'm supposed to check in tests/browserify-public/browserify-bundle.js as well. If necessary, I can add to PR.

@pgte pgte merged commit cbf8241 into nock:master Feb 15, 2016
@pgte
Copy link
Member

pgte commented Feb 15, 2016

@owiber thanks!

Fix landed in v7.2.1.

@owiber owiber deleted the oliver-callbackfix branch February 18, 2016 18:47
@lock
Copy link

lock bot commented Sep 14, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Sep 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants