Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocessor define with arguments including whitespace #110

Closed
AndreasOM opened this issue Jan 16, 2020 · 6 comments
Closed

Preprocessor define with arguments including whitespace #110

AndreasOM opened this issue Jan 16, 2020 · 6 comments

Comments

@AndreasOM
Copy link

Would be nice to support the following too:

#define FOO( x, y ) ( x + y )

(Mind the spaces inside the braces!)

@hadronized
Copy link
Owner

You mean the parens? Well, that should be supported already. 🤔 If not, I guess it’s a bug.

@AndreasOM
Copy link
Author

I mean the spaces inside the braces.
I saw #99 , but that fixed only half the problem.

@hadronized
Copy link
Owner

I meant the parens. Braces are { }. Anyway, that should already be supported. I’ll make some inquiries.

@hadronized
Copy link
Owner

hadronized commented Jan 17, 2020

If anyone sees this and wants to work on it, please they branch from fix/cpp-define-spaces. The fix should be trivial but I don’t have time to do it until at least Sat night.

@hadronized
Copy link
Owner

Released as part of glsl-4.0.1. Thanks for the feedback! Please feel free to try again by running cargo update and close the issue when you witness the fix! :)

@AndreasOM
Copy link
Author

Works for my test cases!

Closing... thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants