Add multi_windows and dict support #133

yehuohan · 2021-07-26T17:43:36Z

Add multi_windows support for [Feature] Please support multi window like easymotion #10.
Add dict support for HopChar and HopPattern. With this commit, we can add dict for other language easily, even support dict for number, emoji and punctation, etc.
Add preview for HopPattern like (easymotion-sn) what does. As it's based on dict pattern, so it supports dict preview alse.

delphinus · 2021-07-28T02:09:37Z

Cool features! I PR-ed #39 that has the similar feature. It uses a calculated dict for :HopChar1, and an external binary for :HopChar2. (#39 does not support :HopPattern with this reason.)

I want to merge here and #39 if possible, so that many people are happy to hop!

yehuohan · 2021-07-28T15:37:56Z

@delphinus With pleasure to hear more dict support. How would you like to merge cmigemo dict? Would you like commit your cmigemo dict to multi-windows branch and then I bypass here or any other way you would like?
By the way, I see there are some punctations such as , . ! in utf-8.lua. Is it possible to collect those punctations to a single dict-lua file?

delphinus · 2021-07-29T23:34:50Z

I transformed this dict (utf-8.lua) from vim-easymotion's one. The original already has punctuation entries and they have Japanese-specific Regexp.

Such as, we can hop by , into these characters below.

, -- U+002C COMMA
， -- U+FF0C FULLWIDTH COMMA
、 -- U+3001 IDEOGRAPHIC COMMA

2. & 3. are used only in Japanese, so it is not so useful that we separate them from utf-8.lua.

yehuohan · 2021-07-30T16:42:53Z

Think for you reply. It's true that I thought it too simple. When I look back, I find out that taking punctations as part of a language is better and we don't need to maintain the difference of punctations that various language use.

delphinus · 2021-08-01T01:07:11Z

Ah, I see. But I think it is difficult to solve “What are punctuation marks?”. Because some symbols include Japanese-specific regexp, ones from vim-easymotion at least. 🤔

  -- "感嘆符" means ! in Japanese
  ['!'] = [=[\%([≠！!]\|感\_s*嘆\_s*符\)]=],
  -- 〃 is a CJK ditto mark, that is not a quotation
  ['"'] = [=[[”″“〃"]]=],

……

  -- "パーセント" means % in Japanese
  ['%'] = [=[\%([％‰%]\|パ\_s*ー\_s*セ\_s*ン\_s*ト\)]=],
  -- "アンド", "アンパサンド" means & in Japanese
  ['&'] = [=[\%([＆&]\|ア\_s*ン\_s*\%(ド\|パ\_s*サ\_s*ン\_s*ド\)\)]=],
  -- "アポストロフィ" means ' in Japanese.
  -- "ズ" is for the possessive case or the plural form.
  ["'"] = [=[\%([ズ”″‘′´’'']\|ア\_s*ポ\_s*ス\_s*ト\_s*ロ\_s*フ\_s*ィ\)]=],

……

As one solution, it should be good that we limit “punctuation marks” to .,:; only -- I think this does not make much sense only 4 entries.

yehuohan · 2021-08-01T01:51:37Z

It's seemd that I didn't commet clear. I said taking punctations as part of a language is saying that I think we place punctuations to language lua file (like the cmigemo dict file) is better. :)

hadronized · 2021-08-08T17:16:34Z

Thanks for the PR, I’ll have a look asap.

yehuohan · 2021-08-15T08:53:31Z

Add commits to fix the issue of different windows with the same buffer:

The old stratagy: use the window with biggest area from different windows with the same buffer.
The new stratagy: crop the duplicated lines area of different windows with the same buffer.

The main change is tocrop_winlines function. Hope this won't disturb your code review.

hadronized · 2021-08-18T23:25:08Z

doc/hop.txt

+    Defaults:~
+        `multi_windows = false`
+
+`dict_list`


The name of this configuration variable is not explicit enough. Can you change it to something that conveys what it’s used for?

How about match_mappings or search_mappings? Means that extending the match space via mapping the pattern to what match_mappings provided.

hadronized · 2021-08-18T23:26:50Z

lua/hop/dict/ascii.lua

@@ -0,0 +1,98 @@
+-- Ascii


Eh, this is going to generate a regression in lots of configuration, starting with mine, where I use unicode on some of my keys (I’m using the bépo layout, so é is a direct key to me).

Not sure this is a good idea to do it that way.

I think I had ignored the case for different layout. And for users who use bépo layout, the key of dict from ascii.lua may be unicode keys, but not only the ascii keys.
I fix the issue by rename ascci.lua to zh.lua ( and add some unicode mappings to zh.lua used in Chinese language ), meaning zh.lua is a basic mappings to Chinese language.

hadronized · 2021-08-18T23:31:42Z

lua/hop/hint.lua

+    local dict_char_pat = ''
+    -- checkout dict-char pattern from each dict
+    for _, v in ipairs(opts.dict_list) do
+      local val = require('hop.dict.' .. v)[char]


I’m not sure how caching will be done by the Lua runtime here but even then I’m not liking this style, especially because that loop could be partially moved out to prevent having to get the cached dict.

How about executing dict require at setup()?
This commit is a simple fix to this issue. If it's a correct fix, I'm pleasure to merge it to this PR.

hadronized · 2021-10-12T17:53:53Z

Can you resolve your conflicts so that we I can review properly? I haven’t had to review lately.

yehuohan · 2021-10-18T16:39:49Z

Can you resolve your conflicts so that we I can review properly? I haven’t had to review lately.

I rebased this PR into a new branch new-multi-windows. But I'm not familar with the api nvim_buf_set_extmark and got a issue with end_col value outside range even with running a simple code below with source %:

"test script

let g:ns = nvim_create_namespace('test')
call nvim_buf_set_extmark(0, g:ns , 0, 0, {
    \ 'end_line': 1,
    \ 'end_col': 2,
    \ 'hl_group': 'Question',
    \ 'hl_eol': v:true,
    \ 'priority': 100 })

@phaazon Do you have any idea about the end_col parameter?

yehuohan · 2021-10-27T15:05:16Z

Can you resolve your conflicts so that we I can review properly? I haven’t had to review lately.

I rebased this PR into a new branch new-multi-windows. But I'm not familar with the api nvim_buf_set_extmark and got a issue with end_col value outside range even with running a simple code below with source %:
"test script

let g:ns = nvim_create_namespace('test')
call nvim_buf_set_extmark(0, g:ns , 0, 0, {
    \ 'end_line': 1,
    \ 'end_col': 2,
    \ 'hl_group': 'Question',
    \ 'hl_eol': v:true,
    \ 'priority': 100 })
@phaazon Do you have any idea about the end_col parameter?

My fault. I mixed up that end_col is 0-based exclusive while end_line is 0-based inclusive.

@phaazon Now multi_windows and match_mappings are resovled into two commits for review.

hadronized · 2021-11-05T18:53:59Z

This PR has been around for a long time and its scope is too wide (multi window, dict, previews). I’m going to close this, especially because of the conflicts. This is probably my fault because of the recent (big) redesign that I did to ship Hop v1.0 along with the extensions support.

However, I would happily review a subset of that PR for the multi-window support as a priority, as people are asking for it and I see that as a top-1 feature for Hop.

For dict support and previews, one PR each is clearly something I would like to review too.

Don’t hesitate to re-open 3 PRs @yehuohan for those topics.

yehuohan · 2021-11-08T15:07:16Z

Thank your comment and I'll split out each feature as single PR with the new plugin API.

hiberabyss · 2022-06-10T08:32:57Z

Thank your comment and I'll split out each feature as single PR with the new plugin API.

@yehuohan The dict feature could be very useful! Is there any progress? Thanks!

yehuohan · 2022-06-12T12:27:28Z

Thank your comment and I'll split out each feature as single PR with the new plugin API.

@yehuohan The dict feature could be very useful! Is there any progress? Thanks!

Glad to hear that those features are helpful. And yeah, new PRs had been opened: #236 #235 #205

This was referenced Jul 27, 2021

Add empty line support for HopLineStart #131

Closed

Add dict support #128

Closed

yehuohan changed the title ~~Add multi_windows support~~ Add multi_windows and dict support Jul 27, 2021

yehuohan mentioned this pull request Aug 1, 2021

add dict support easymotion/vim-easymotion#444

Open

hadronized requested changes Aug 18, 2021

View reviewed changes

rish987 mentioned this pull request Sep 22, 2021

Merge #123 and #133, fixes and refactors #153

Closed

jdhao mentioned this pull request Oct 17, 2021

Replace vim-sneak with hop.nvim? jdhao/nvim-config#21

Closed

yehuohan added 2 commits October 27, 2021 22:48

Add multi_windows with supporing pattern preview

22dc1a2

Add match_mappings to extend the match space of hop

161dbed

yehuohan force-pushed the multi-windows branch from 0aac6c9 to 161dbed Compare October 27, 2021 14:58

hadronized closed this Nov 5, 2021

yehuohan mentioned this pull request Dec 18, 2021

Add multi_windows support #205

Merged

yehuohan mentioned this pull request Feb 13, 2022

fix: skip foldline's targets #222

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add multi_windows and dict support #133

Add multi_windows and dict support #133

yehuohan commented Jul 26, 2021 •

edited

delphinus commented Jul 28, 2021

yehuohan commented Jul 28, 2021 •

edited

delphinus commented Jul 29, 2021

yehuohan commented Jul 30, 2021

delphinus commented Aug 1, 2021

yehuohan commented Aug 1, 2021

hadronized commented Aug 8, 2021

yehuohan commented Aug 15, 2021

hadronized Aug 18, 2021

yehuohan Aug 21, 2021

hadronized Aug 18, 2021

yehuohan Aug 21, 2021

hadronized Aug 18, 2021

yehuohan Aug 21, 2021

hadronized commented Oct 12, 2021

yehuohan commented Oct 18, 2021

yehuohan commented Oct 27, 2021 •

edited

hadronized commented Nov 5, 2021

yehuohan commented Nov 8, 2021

hiberabyss commented Jun 10, 2022

yehuohan commented Jun 12, 2022 •

edited

Add multi_windows and dict support #133

Add multi_windows and dict support #133

Conversation

yehuohan commented Jul 26, 2021 • edited

delphinus commented Jul 28, 2021

yehuohan commented Jul 28, 2021 • edited

delphinus commented Jul 29, 2021

yehuohan commented Jul 30, 2021

delphinus commented Aug 1, 2021

yehuohan commented Aug 1, 2021

hadronized commented Aug 8, 2021

yehuohan commented Aug 15, 2021

hadronized Aug 18, 2021

Choose a reason for hiding this comment

yehuohan Aug 21, 2021

Choose a reason for hiding this comment

hadronized Aug 18, 2021

Choose a reason for hiding this comment

yehuohan Aug 21, 2021

Choose a reason for hiding this comment

hadronized Aug 18, 2021

Choose a reason for hiding this comment

yehuohan Aug 21, 2021

Choose a reason for hiding this comment

hadronized commented Oct 12, 2021

yehuohan commented Oct 18, 2021

yehuohan commented Oct 27, 2021 • edited

hadronized commented Nov 5, 2021

yehuohan commented Nov 8, 2021

hiberabyss commented Jun 10, 2022

yehuohan commented Jun 12, 2022 • edited

yehuohan commented Jul 26, 2021 •

edited

yehuohan commented Jul 28, 2021 •

edited

yehuohan commented Oct 27, 2021 •

edited

yehuohan commented Jun 12, 2022 •

edited