Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff errors when commits include removed submodule #339

Closed
scott-fleischman opened this issue Oct 30, 2018 · 1 comment
Closed

Diff errors when commits include removed submodule #339

scott-fleischman opened this issue Oct 30, 2018 · 1 comment

Comments

@scott-fleischman
Copy link
Contributor

The following returns an error:

GitHub.Commits.diff "scott-fleischman" "repo-remove-submodule" "d03c152482169d809be9b1eab71dcf64d7405f76" "42cfd732b20cd093534f246e630b309186eb485d"

Left (ParseError "Error in $[2]['blob_url']: failed to parse field files: expected URL, encountered Null")

You can see the example here with the response JSON:
https://github.com/scott-fleischman/repo-remove-submodule

Would you be ok with a change like the following? If so I can put together a PR.

data File = File
    { fileBlobUrl   :: !(Maybe URL)
    , fileStatus    :: !Text
    , fileRawUrl    :: !(Maybe URL)
    , fileAdditions :: !Int
@phadej
Copy link
Contributor

phadej commented Oct 30, 2018

Please, make a PR!

@scott-fleischman scott-fleischman mentioned this issue Oct 30, 2018
Merged
@phadej phadej closed this as completed in b56dd76 Feb 4, 2019
phadej added a commit that referenced this issue Feb 4, 2019
@phadej
Merge pull request #340 from scott-fleischman/issue-339
6ac12e4 
Make fileBlobUrl and fileRawUrl optional; Fix #339.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phadej @scott-fleischman