Add Statuses endpoints #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phadej
suggested changes
Apr 6, 2017
| createStatus :: Auth -> Name Owner -> Name Repo -> Name Commit -> NewStatus -> IO (Either Error Status) | ||
| createStatus auth owner repo sha ns = | ||
| executeRequest auth $ createStatusR owner repo sha ns | ||
|
|
There was a problem hiding this comment.
could you add links to the relevant parts of github docs here as haddocks, and to Github.hs module explicitly, so we get a nice overview of api: http://hackage.haskell.org/package/github-0.15.0/docs/GitHub.html
|
While James has seemingly abandoned this, could we still get it merged? I just wasted an evening rewriting this exact PR |
|
Apologies - I missed those earlier notifications. I’ll add that documentation shortly. |
|
Okay, rebased and updated the docs. Let me know if I missed anything @phadej. Thanks! |
phadej
approved these changes
Nov 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://developer.github.com/v3/repos/statuses
I'm working on writing a CI-style service which receives a webhook and posts statuses back. I'm mostly interested in create status, but did a quick smoketest of the other ones and they seemed to work fine.
What's preferred in terms of tests, examples, documentation? I'm happy to write any of those, but would appreciate a reference.
#259 (and #256)