Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requested reviewers field to pull request records #292

Merged
merged 1 commit into from
Nov 9, 2017
Merged

Add requested reviewers field to pull request records #292

merged 1 commit into from
Nov 9, 2017

Conversation

toddmohney
Copy link
Contributor

From the GitHub Api docs

Deliveries for review_requested and review_request_removed events will have an additional field called requested_reviewers.

Adds simplePullRequestRequestedReviewers and pullRequestRequestedReviewers fields to SimplePullRequest and PullRequest respectively.

@toddmohney
Copy link
Contributor Author

Hmm... couldn't seem to get the build to pass here without the update to the .travisci file. The changes are a result of running the travis encrypt command from the README and likely an undesirable change to merge into master.

The reason I ran the travis encrypt command was because of GitHub auth errors on my travis account where I have a fork of this repo. Any advice here?

@toddmohney
Copy link
Contributor Author

Removing the .travisci file changes and trying again...

@phadej phadej merged commit 1e357e5 into haskell-github:master Nov 9, 2017
@toddmohney toddmohney deleted the add-requested-reviewers branch November 9, 2017 21:25
@phadej phadej added this to the 0.18 milestone Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants