Fix doc examples #357
Merged
Fix doc examples #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phadej
reviewed
Apr 7, 2019
src/GitHub.hs
Outdated
| @@ -7,7 +7,7 @@ | |||
| -- this package. | |||
| -- | |||
| -- See "GitHub.Request" module for executing 'Request', or other modules | |||
| -- of this package (e.g. "GitHub.Users") for already composed versions. | |||
| -- of this package (e.g. "GitHub.Data.Users") for already composed versions. | |||
There was a problem hiding this comment.
this is incorrect. (some) "composed" requests are in Endpoints modules, in this case e.g. http://hackage.haskell.org/package/github-0.21/docs/GitHub-Endpoints-Users.html
|
@phadej I think it's ready to merge |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@phadej I'm absolutely delighted by this package. It's so well documented and easy to use. You're doing great work for Haskell community. Thank you!
This PR fixes most documentation examples that didn't work with the current version of the package.