Teams improvements #417
Closed
Teams improvements #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Few samples broke |
phadej
reviewed
Dec 3, 2019
The privacy field was previously commented out while the privacy level of a team was part of the `ironman` API preview. This feature is now part of the official v3 API, so this commit adds support for this field.
The `privacy` field is optional when creating/editing teams, but has a context dependent default value. When getting the team details, the field is expected to always be populated due to these default values.
robbiemcmichael
force-pushed
the
teams-improvements
branch
from
91187f6
to
b2275d1
Compare
|
@phadej Good point, I've updated to make it optional when creating/editing teams. Since it always has a default value, it looks like the |
phadej
suggested changes
Dec 3, 2019
Makes team `privacy` and `permission` fields required when creating a team so users are forced to choose, but optional when editing a team.
|
@phadej Updated as requested. |
|
amended and merged as part of #446, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three changes:
Fix permission field in types for teams
Fixes a bug as the field is
permissionnotpermissions.Add privacy field to types for teams
The privacy field was previously commented out while the privacy level of a team was part of the
ironmanAPI preview. This feature is now part of the official v3 API, so this commit adds support for this field.Make privacy field non-optional in teams
The
privacyfield is optional when creating/editing teams, but has a context dependent default value. When getting the team details, the field is expected to always be populated due to these default values.I could also add the
ldap_dnfield mentioned in #416 as part of this pull request, but I chose not to as I suspect you may not want to support undocumented fields.