Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage orgs in GitHub Enterprise #420

Merged

Conversation

robbiemcmichael
Copy link
Contributor

Adds the two endpoints for managing orgs in GitHub Enterprise.

Happy to discuss in this PR whether the github library should support GitHub Enterprise features. I've put the first Organizations module under GitHub.Endpoints.Enterprise to try to make it clear that the endpoint isn't supported in the github.com API.

@phadej
Copy link
Contributor

phadej commented Dec 16, 2019

Supporting enterprise endpoints is ok.

We should create a GitHub.Enterprise top-level module re-exporting all enterprise endpoints, so you could get everything just by

import GitHub as GH
import GitHub.Enterpise as GH

@robbiemcmichael
Copy link
Contributor Author

@phadej Good idea. I've pushed an extra commit, let me know if that's what you had in mind.

@phadej
Copy link
Contributor

phadej commented Dec 16, 2019

@robbiemcmichael that's exactly what I had in mind, thanks!

I'll merge once CI is green.

@robbiemcmichael
Copy link
Contributor Author

@phadej Is anything else needed here before this one can be merged?

@phadej phadej merged commit abc4fff into haskell-github:master Feb 11, 2020
@phadej
Copy link
Contributor

phadej commented Feb 11, 2020

A ping, clearly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants