-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty popup #30
Comments
OscarDeDios, thanks for fixing this. Awesome! |
You are wellcome @pepri . I like a lot this extension, to see the statistics of my extensions is one of the first things I do every morning I needed fixed quikly ;-) |
Am I the only one still seeing this issue? I have the latest version and I'm seeing nothing in the popup and the options page is broken. Both have the following errors in the console:
Anyone got any ideas. It looks to me like the update package was corrupt or something. |
That's weird. Repacked and resubmitted. Hopefully this will fix it. If not, we take it from there. |
Sorry for the late response. I can't test on the machine I originally noticed this on right now, but it appears to work fine on my work laptop, meaning that the latest version is fixed. If it's still broken on my home machine, I'll reinstall the extension. Thanks for fixing it. |
Thank you for reporting :-) |
In Chrome 35+, the popup action has no content.
The exception is:
Uncaught ReferenceError: webkitNotifications is not defined
The problem is in js.js:2149
The webkitNotifications should be accessed using the global object (add the "window."):
if(!( window.webkitNotifications && webkitNotifications.createNotification)) {
Thanks for your extension.
Edit: Actually, the proper fix would be to change it to use Notification object instead of webkitNotifications.
The text was updated successfully, but these errors were encountered: