Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty popup #30

Closed
pepri opened this issue May 29, 2014 · 6 comments
Closed

Empty popup #30

pepri opened this issue May 29, 2014 · 6 comments

Comments

@pepri
Copy link

pepri commented May 29, 2014

In Chrome 35+, the popup action has no content.

The exception is:
Uncaught ReferenceError: webkitNotifications is not defined

The problem is in js.js:2149

The webkitNotifications should be accessed using the global object (add the "window."):
if(!( window.webkitNotifications && webkitNotifications.createNotification)) {

Thanks for your extension.

Edit: Actually, the proper fix would be to change it to use Notification object instead of webkitNotifications.

@pepri
Copy link
Author

pepri commented May 30, 2014

OscarDeDios, thanks for fixing this. Awesome!

@pepri pepri closed this as completed May 30, 2014
@OscarDeDios
Copy link
Contributor

You are wellcome @pepri . I like a lot this extension, to see the statistics of my extensions is one of the first things I do every morning I needed fixed quikly ;-)

@neocotic
Copy link
Contributor

Am I the only one still seeing this issue? I have the latest version and I'm seeing nothing in the popup and the options page is broken. Both have the following errors in the console:

Failed to load resource: net::ERR_FILE_NOT_FOUND chrome-extension://igejgfmbjjjjplnnlgnbejpkpdajkblm/js/core-lite.js
Failed to load resource: net::ERR_FILE_NOT_FOUND chrome-extension://igejgfmbjjjjplnnlgnbejpkpdajkblm/js/js.js
Failed to load resource: net::ERR_FILE_NOT_FOUND chrome-extension://igejgfmbjjjjplnnlgnbejpkpdajkblm/js/background.js

Anyone got any ideas. It looks to me like the update package was corrupt or something.

@phaistonian
Copy link
Owner

That's weird.

Repacked and resubmitted.

Hopefully this will fix it. If not, we take it from there.

@phaistonian phaistonian reopened this May 31, 2014
@neocotic
Copy link
Contributor

neocotic commented Jun 2, 2014

Sorry for the late response. I can't test on the machine I originally noticed this on right now, but it appears to work fine on my work laptop, meaning that the latest version is fixed. If it's still broken on my home machine, I'll reinstall the extension.

Thanks for fixing it.

@phaistonian
Copy link
Owner

Thank you for reporting :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants