Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decimal and Float Column size is not saving #92

Closed
jdubreville opened this issue May 5, 2020 · 2 comments
Closed

Decimal and Float Column size is not saving #92

jdubreville opened this issue May 5, 2020 · 2 comments

Comments

@jdubreville
Copy link

When generating a migration the size of a decimal and float column is not being saved as it was in previous versions. This prevents the migration from being pushed forward and you will get an error that Float(M,D) or Decimal(M,D) and that M must always be >= D.

@jdubreville
Copy link
Author

So I dug in a little more and Float and Decimal are in the noSizeTypes list which I don't think this is correct for MySql as the size is the precision of the number being stored. I don't mind making a pull request for this but it would need to update back to 1.2 and up.

@Jeckerson Jeckerson self-assigned this May 17, 2020
@Jeckerson
Copy link
Member

Jeckerson commented Aug 29, 2020

@jdubreville Could you make an PR please? Or example little bit better with some example.

@Jeckerson Jeckerson removed their assignment Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants