Merge pull request #935 from dreamsxin/OPERATORS

Fix bug about GreaterEqualOperator
zephir-lang · May 4, 2015 · 09e3ac3 · 09e3ac3
2 parents b0412a0 + 947f2e4
commit 09e3ac3
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/Library/Operators/Comparison/GreaterEqualOperator.php b/Library/Operators/Comparison/GreaterEqualOperator.php
@@ -30,5 +30,5 @@ class GreaterEqualOperator extends ComparisonBaseOperator
 
     protected $_zvalLongOperator = 'ZEPHIR_GE_LONG';
 
-    protected $_zvalLongNegOperator = 'ZEPHIR_LT_LONG';
+    protected $_zvalLongNegOperator = 'ZEPHIR_LE_LONG';
 }
diff --git a/test/compare.zep b/test/compare.zep
@@ -9,6 +9,11 @@ class Compare
 		return a < b;
 	}
 
+	public function isGreaterEqual(int a, int b)
+	{
+		return a >= b;
+	}
+
 	public function isLessDouble(double a, double b)
 	{
 		return a < b;

diff --git a/unit-tests/Extension/CompareTest.php b/unit-tests/Extension/CompareTest.php
@@ -32,6 +32,15 @@ public function testLess()
         $this->assertFalse($t->isLessInt(20, 10));
     }
 
+    public function testGreaterEqual()
+    {
+        $t = new Compare;
+
+        $this->assertTrue($t->isGreaterEqual(3, 2));
+        $this->assertTrue($t->isGreaterEqual(2, 2));
+        $this->assertFalse($t->isGreaterEqual(1, 2));
+    }
+
     public function testConst()
     {
         $t = new Compare;