Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed invalid ZEPHIR_METHOD_GLOBALS_PTR call #1942

Merged
merged 2 commits into from Oct 3, 2019

Conversation

sergeyklay
Copy link
Member

Hello!

In raising this pull request, I confirm the following:

  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Fixed invalid zephir_json_encode and zephir_json_decode call or those users who doesn't use
bundled ext/json/php_json.h

Thanks

@codecov
Copy link

codecov bot commented Oct 3, 2019

Codecov Report

Merging #1942 into development will decrease coverage by <.01%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             development    #1942      +/-   ##
=================================================
- Coverage          33.99%   33.99%   -0.01%     
  Complexity          8252     8252              
=================================================
  Files                561      561              
  Lines              44931    44930       -1     
=================================================
- Hits               15275    15274       -1     
  Misses             29656    29656

@sergeyklay sergeyklay merged commit 82974d3 into development Oct 3, 2019
@sergeyklay sergeyklay deleted the fix/1940-build-command branch October 3, 2019 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants