PhanAbstractStaticMethodCallInStatic Potentially calling an abstract static method

[westerp]

Phan version 3.1.1, and dev-master

Valid PHP:

<?php

abstract class Base
{
    abstract protected static function getInstance();

    /**
     * @return static
     */
    public static function get()
    {
        return static::getInstance();
    }
}

class TestImpl
{
    protected static function getInstance()
    {
        return new TestImpl();
    }
}

// Example usage
$obj = TestImpl::get();

Reports:

Test.php:13 PhanAbstractStaticMethodCallInStatic Potentially calling an abstract static 
method \Test::getInstance() with static:: in static::getInstance() 
(the calling static method's class scope may be an abstract class)

Expected: no errors

[TysonAndre]

This is by design, and was intended to be added in #3799

The issue is emitted because code that isn't analyzed can call Base::get() directly, and the only place where it makes sense to warn is in the implementation of get() itself, or abstract class OtherBase extends Base. (i.e. (the calling static method's class scope may be an abstract class))

[TysonAndre]

It's recommended that you suppress the issue (either globally, or just for the method declaration in question) and document that the methods are only meant to be called on concrete classes