New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting `PhanCompatibleNonCapturingCatch` on PHP 8 #4433

Closed

januszmk opened this issue May 29, 2021 · 0 comments

januszmk commented May 29, 2021

Hi,
I am getting this error:
src/XXXXX.php:110 PhanCompatibleNonCapturingCatch Catching exceptions without a variable is not supported before PHP 8.0 in catch (GuzzleException), but I am on php 8.0

Phan 4.0.6
php-ast version 1.0.11
PHP version used to run Phan: 8.0.3

in .phan/config I set target_php_version and minimum_target_php_version to '8.0'. I also have backward_compatibility_checks set to false.
it looks like this: https://github.com/phan/phan/blob/4.0.6/src/Phan/Analysis/PreOrderAnalysisVisitor.php#L753 just doesn't check for php version

The text was updated successfully, but these errors were encountered:

TysonAndre closed this as completed in

e8b859d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment