False Positive: PhanPluginMixedKeyNoKey Should not mix array entries

[andrei-dascalu]

version: 5.4.2

Given the following code

class SomeClass
{
    /**
     * @return array<string,string>
     */
    public function doSomething(): array
    {
        /** @var array<string,string> $response */
        $response = [
            'result' => 'result',
        ];

        return [
            ...$response,
            'another' => 'bar',
        ];
    }
}

results in

src/SomeClass.php:16 PhanPluginMixedKeyNoKey Should not mix array entries of the form [key => value,] with entries of the form [value,]

Seems that Phan doesn't correctly interpret the effects of the ... operator on <string,string> arrays ?

[Jimbolino]

This problem still exists in the latest version.

class SomeClass
{
    public function doSomething(): array
    {
        $response = [
            'result' => 'result',
        ];

        return [
            ...$response, // PhanPluginMixedKeyNoKey here
            'another' => 'bar',
        ];
    }
}

src/example.php:12 PhanPluginMixedKeyNoKey Should not mix array entries of the form [key => value,] with entries of the form [value,].

Probably the spread operator is not understood correctly