Skip to content

Commit

Permalink
Apply fixes from StyleCI (#632)
Browse files Browse the repository at this point in the history
  • Loading branch information
phanan committed Aug 5, 2017
1 parent 39e8377 commit 56cbb4f
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 10 deletions.
8 changes: 4 additions & 4 deletions app/Models/Album.php
Expand Up @@ -144,8 +144,8 @@ public function generateCover(array $cover)
* Write a cover image file with binary data and update the Album with the new cover file.
*
* @param string $binaryData
* @param string $extension The file extension
* @param string $destination The destination path. Automatically generated if empty.
* @param string $extension The file extension
* @param string $destination The destination path. Automatically generated if empty.
*/
public function writeCoverFile($binaryData, $extension, $destination = '')
{
Expand All @@ -159,8 +159,8 @@ public function writeCoverFile($binaryData, $extension, $destination = '')
/**
* Copy a cover file from an existing image on the system.
*
* @param string $source The original image's full path.
* @param string $destination The destination path. Automatically generated if empty.
* @param string $source The original image's full path.
* @param string $destination The destination path. Automatically generated if empty.
*/
public function copyCoverFile($source, $destination = '')
{
Expand Down
6 changes: 3 additions & 3 deletions app/Models/Artist.php
Expand Up @@ -65,7 +65,7 @@ public function getIsUnknownAttribute()
}

/**
* Indicate if the artist is the special "Various Artists"
* Indicate if the artist is the special "Various Artists".
*
* @return bool
*/
Expand Down Expand Up @@ -149,8 +149,8 @@ public function getInfo()
* Write an artist image file with binary data and update the Artist with the new cover file.
*
* @param string $binaryData
* @param string $extension The file extension
* @param string $destination The destination path. Automatically generated if empty.
* @param string $extension The file extension
* @param string $destination The destination path. Automatically generated if empty.
*/
public function writeImageFile($binaryData, $extension, $destination = '')
{
Expand Down
2 changes: 1 addition & 1 deletion app/Models/Song.php
Expand Up @@ -332,7 +332,7 @@ public function setTitleAttribute($value)
* Some songs don't have a title.
* Fall back to the file name (without extension) for such.
*
* @param string $value
* @param string $value
*
* @return string
*/
Expand Down
2 changes: 1 addition & 1 deletion tests/Feature/TestCase.php
Expand Up @@ -21,7 +21,7 @@ public function setUp()
$this->prepareForTests();
}

/**
/**
* Create a sample media set, with a complete artist+album+song trio.
*/
protected function createSampleMediaSet()
Expand Down
1 change: 1 addition & 0 deletions tests/Unit/SongTest.php
Expand Up @@ -26,6 +26,7 @@ public function it_can_be_retrieved_using_its_path()
// Then the song is retrieved
$this->assertEquals($song->id, $retrieved->id);
}

/** @test */
public function its_lyrics_has_all_new_line_characters_replace_by_br_tags()
{
Expand Down
2 changes: 1 addition & 1 deletion tests/Unit/SongZipArchiveTest.php
Expand Up @@ -46,7 +46,7 @@ public function multiple_songs_can_be_added_into_an_archive()
]),
factory(Song::class)->create([
'path' => realpath(__DIR__.'/../songs/lorem.mp3'),
])
]),
]);

// When I add the songs into the archive
Expand Down

0 comments on commit 56cbb4f

Please sign in to comment.