Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop hiding buffs for enemies #10

Closed
funkydude opened this issue Aug 14, 2016 · 6 comments
Closed

Stop hiding buffs for enemies #10

funkydude opened this issue Aug 14, 2016 · 6 comments

Comments

@funkydude
Copy link

When it comes to enemies, I don't want to hold SHIFT to see what beneficial buffs it has.

Maybe you did this for PvP, in which case you should stop hiding them for NPCs where gaining a buff means you need to take some form of action, such as dispelling, or using a cooldown.

@funkydude
Copy link
Author

I'm also noticing a lot of the time even holding shift won't reveal everything. For example, holding shift on an ally would not show me this debuff: http://www.wowhead.com/spell=204813/blindfold

Infact holding shift didn't show me anything on them.

@Phanx
Copy link
Member

Phanx commented Aug 17, 2016

Dispellable buffs on enemies (whether they're players or NPCs) should trigger the dispel highlight. If you're not seeing that, more information (which buff or debuff, which class and spec) would be useful.

Other than that, I agree that there's not really any reason to hide buffs on NPCs, but I've also never noticed their lack either. Anything important is either dispellable (see above) or my boss mods tell me about it. Showing them is probably not a big deal, though, since NPCs are unlikely to have a ton of buffs. I'll go ahead and show anything with a duration of less than an hour (should rule out "aura" type buffs that are always on and you can't do anything about).

I'll look into the shift toggle. Keep in mind it's ignored during combat. Also, there's a limit on how many aura icons are shown, based on your frame width setting. I guess I can add another row of icons. Are there any specific types of buffs you're mainly concerned with? The only reason the shift toggle exists in the first place is because I wanted to be able to see what mounts people were using.

@funkydude
Copy link
Author

I'll go ahead and show anything with a duration of less than an hour (should rule out "aura" type buffs that are always on and you can't do anything about).

Awesome.

Keep in mind it's ignored during combat.

This was during combat :(
As a boss mod author, seeing a boss debuff on someone makes me think "oh I better look at the log for that" when I don't see one, I sometimes don't even bother and assume it's yet another hidden debuff (a common issue)

I guess I can add another row of icons.

That would be cool, but in this case, it wasn't a problem of too many icons, I don't think. I'm not sure, since I couldn't see any buffs/debuffs (in combat). There should hopefully be less of a concern with the buff removals in this patch.

I can't really say specific debuffs, I guess I'd like shift to be a "show everything" if that's possible, the second row would help with that.

@Phanx
Copy link
Member

Phanx commented Aug 17, 2016

As a boss mod author, seeing a boss debuff on someone ...

Anything flagged as a boss aura should already be shown on everyone (players and NPCs) unless it's specifically blacklisted. (Actually, looking at the code now, boss auras aren't whitelisted on party/focus/TOT frames; I'll fix that now.)

Phanx added a commit that referenced this issue Aug 17, 2016
@funkydude
Copy link
Author

Not sure if this was the intention heh
debuffs

@Phanx
Copy link
Member

Phanx commented Aug 19, 2016 via email

@Phanx Phanx closed this as completed in c6cec3f Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants