Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Github Rate-Limit #127

Closed
theseer opened this issue Dec 15, 2017 · 3 comments
Closed

Handle Github Rate-Limit #127

theseer opened this issue Dec 15, 2017 · 3 comments
Milestone

Comments

@theseer
Copy link
Member

theseer commented Dec 15, 2017

In case of a 403 error on github's API, we should probably check for a Rate Limit and report a better error message in case it is.

@Ayesh
Copy link
Contributor

Ayesh commented Dec 16, 2017

👍 for better error message. Perhaps it's better if we expose an option, preferably from a file, to set an OAuth key so the rate limits can be high as 5000 req/hr.

@theseer
Copy link
Member Author

theseer commented Dec 16, 2017

We in general need to add support for means of authentication like for private repositories. That's a different issue though.

@sebastianheuer
Copy link
Member

As of 4f9b71f it is possible to set a GitHub Auth Token via the GITHUB_AUTH_TOKEN environment variable. We will probably add other ways to configure this, but environment variables are usually supported by CI tools out of the box, so we figured this was a good first step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants