Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix array access in gitlab repo #373

Merged
merged 1 commit into from Jul 8, 2022

Conversation

chrfritsch
Copy link

@chrfritsch chrfritsch commented Jul 8, 2022

I just added a custom repositories.xml to my project with a link to our gitlab instance. The download of the phar didn't work because the parsed JSON returns an array and not an object.

@theseer theseer merged commit dac3e6f into phar-io:master Jul 8, 2022
@theseer
Copy link
Member

theseer commented Jul 8, 2022

Can you fix the tests please?

@chrfritsch
Copy link
Author

Tests didn't ran for this PR. Can you enable them?

@chrfritsch
Copy link
Author

@theseer Here is a new PR with fixed tests #375

After that is merged, could you please create a new release. That would really help us. Thank you.

@theseer
Copy link
Member

theseer commented Jul 9, 2022

Will do next week.

@chrfritsch chrfritsch deleted the fix/gitlab-repo branch July 18, 2022 08:14
@chrfritsch
Copy link
Author

@theseer May I ask again for a new release please :)

@theseer
Copy link
Member

theseer commented Jul 28, 2022

Sorry, vacation took over ;)

I'll make a new release tomorrow.

@theseer
Copy link
Member

theseer commented Aug 2, 2022

Sorry for taking long...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants