Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use GPG fingerprint instead of key ID #77

Closed
sebastianheuer opened this issue Aug 17, 2016 · 1 comment
Closed

Always use GPG fingerprint instead of key ID #77

sebastianheuer opened this issue Aug 17, 2016 · 1 comment

Comments

@sebastianheuer
Copy link
Member

The key ID is not a reliable criteria for validating GPG keys: http://www.golem.de/news/keyserver-chaos-mit-doppelten-pgp-key-ids-1608-122733.html

@sebastianheuer sebastianheuer added this to the 0.7.0 milestone Aug 17, 2016
@theseer
Copy link
Member

theseer commented Aug 17, 2016

To clarify this a bit:

As it looks like GnuPG only returns the long key id in --verify operations:

[GNUPG:] BADSIG 9D8A98B29B2D5D79 phar.io <team@phar.io>
[GNUPG:] ERRSIG 4AA394086372C20A 1 10 00 1405769272 9

So we only have the (long) key id to search with at the key servers.
We already show the fingerprint when asking to import the key into the keyring.

But since the key id might not actually be as unique as we thought, there might be multiple keys matching. Phive needs to get enhanced to handle this situation and iterate over candiates.

@sebastianheuer sebastianheuer removed this from the 0.7.0 milestone Apr 20, 2017
@theseer theseer added this to To Do in Next Release Aug 26, 2017
@sebastianheuer sebastianheuer removed this from To Do in Next Release Jul 6, 2018
@theseer theseer closed this as completed Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants