Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Failing CI check - rework derive_var_extreme_flag example #1780

Closed
bms63 opened this issue Feb 28, 2023 · 2 comments · Fixed by #1811
Closed

Bug: Failing CI check - rework derive_var_extreme_flag example #1780

bms63 opened this issue Feb 28, 2023 · 2 comments · Fixed by #1811
Assignees
@zdz2101
Labels
bug Something isn't working programming
Milestone
v0.11

Comments

@bms63
Copy link
Collaborator

bms63 commented Feb 28, 2023

What happened?

CI is occasionally failing for this example. You can rerun the check manually to get it to pass, but this is not ideal

image

Session Information

No response

Reproducible Example

No response
@bms63 bms63 added bug Something isn't working programming release Q2-2023 labels Feb 28, 2023
@bundfussr
Copy link
Collaborator

It is one of the examples where we use admiral.test data (about 30000 observations from VS and 2000 observations from AE). I would expect that #1752 solves the issue.

@bms63
Copy link
Collaborator Author

bms63 commented Feb 28, 2023

I think we should prioritize fixing this one first after the release

@bms63 bms63 mentioned this issue Feb 28, 2023
Closed
4 tasks
@zdz2101 zdz2101 mentioned this issue Mar 3, 2023
Merged
14 tasks
@zdz2101 zdz2101 self-assigned this Mar 7, 2023
@sadchla-codes sadchla-codes mentioned this issue Mar 10, 2023
Closed
@bms63 bms63 linked a pull request Apr 5, 2023 that will close this issue
Closes #1780 Address ci check for runtime of derive_var_extreme_flag() #1811
Merged
14 tasks
@bms63 bms63 added this to the v0.11 milestone May 9, 2023
@bms63 bms63 closed this as completed in 9ce5abb Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zdz2101 zdz2101

Labels
bug Something isn't working programming
Projects
admiral (sdtm/adam, dev, ci, template, core)
Status: Archive
Milestone
v0.11
3 participants
@bms63 @zdz2101 @bundfussr