Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General Issue: Change vars() to exprs() #197

Closed
bundfussr opened this issue Jan 20, 2023 · 0 comments · Fixed by #198
Closed

General Issue: Change vars() to exprs() #197

bundfussr opened this issue Jan 20, 2023 · 0 comments · Fixed by #198
Assignees
@bundfussr
Labels
Documentation Material that provides official information or evidence or that serves as a record. High Priority Important and needing to be done or dealt with quickly Programming release Q1-2023
Projects
admiralonco Project Board

Comments

@bundfussr
Copy link
Collaborator

Background Information

The admiral core team has decided to change from using vars() to exprs() (see pharmaverse/admiral#1627 for details).

The admiralonco functions, vignettes, and templates need to be updated accordingly.

  • In the vignettes and templates all calls to vars() need to be replaced with exprs() and quo_c() with expr_c().
  • In the functions all parameters should expect expressions instead of quosures. For example new_var <- assert_symbol(enquo(new_var) should be updated to new_var <- assert_symbil(enexpr(new_var)).

Definition of Done

No response
@bundfussr bundfussr added Documentation Material that provides official information or evidence or that serves as a record. High Priority Important and needing to be done or dealt with quickly Programming release Q1-2023 labels Jan 20, 2023
@bundfussr bundfussr added this to Backlog in admiralonco Project Board via automation Jan 20, 2023
@bundfussr bundfussr moved this from Backlog to To do - For this sprint in admiralonco Project Board Jan 20, 2023
@bundfussr bundfussr self-assigned this Jan 27, 2023
@bundfussr bundfussr moved this from To do - For this sprint to In progress in admiralonco Project Board Jan 27, 2023
@bundfussr bundfussr linked a pull request Jan 27, 2023 that will close this issue
Closes #197 197_exprs: replace vars() with exprs() #198
Merged
13 tasks
@bundfussr bundfussr moved this from In progress to Done in admiralonco Project Board Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bundfussr bundfussr

Labels
Documentation Material that provides official information or evidence or that serves as a record. High Priority Important and needing to be done or dealt with quickly Programming release Q1-2023
Projects
admiralonco Project Board
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #197 197_exprs: replace vars() with exprs() pharmaverse/admiralonco
1 participant
@bundfussr