Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split admiral_qs into admiralophtha_qs and admiral_qs. #6

Closed
manciniedoardo opened this issue Jun 12, 2023 · 3 comments · Fixed by #45
Closed

Split admiral_qs into admiralophtha_qs and admiral_qs. #6

manciniedoardo opened this issue Jun 12, 2023 · 3 comments · Fixed by #45
Assignees

Comments

@manciniedoardo
Copy link
Collaborator

Background Information

After the completion of #1 we should have the QS dataset from {admiral.test} available in {admiraldata}. This dataset had been originally edited in {admiral.test} to include VFQ parameters upon request from the {admiralophtha} team (see the update_qs script). Now, it would be best to create two copies of the QS SDTM: admiralophtha_qs, which contains everything, and admiral_qs, which does not contain VFQ records.

Note: the {admiralophtha} team has made an update to how the VFQ records are derived (see here for the updated script) so this code should be used instead.

Definition of Done

admiral_qs and admiralophtha_qs as described above present in the data folder and documented in data.R.

@manciniedoardo manciniedoardo changed the title Split admiral_qs into admiralophtha_qs and admiral_qs Split admiral_qs into admiralophtha_qs and admiral_qs. Jun 12, 2023
@bundfussr
Copy link
Contributor

As far as I know admiral_qs is not used. The questionnaires vignette uses example_qs stored in admiral.
Should we move example_qs to admiraldata?
Should we remove admiral_qs?

@bms63
Copy link
Collaborator

bms63 commented Jun 14, 2023

This is a huge datasets and I would say please remove it!!

@kaz462 kaz462 self-assigned this Jun 27, 2023
@kaz462
Copy link
Contributor

kaz462 commented Jun 27, 2023

Agreed in the meeting: remove qs, keep qs_ophtha and qs_example from questionnaires vignette in {pharmaversesdtm}

qs_example has different subject IDs, a clean-up will be needed in a later phase.

@kaz462 kaz462 removed their assignment Jul 13, 2023
@jiegaoo jiegaoo self-assigned this Jul 31, 2023
@kaz462 kaz462 linked a pull request Aug 1, 2023 that will close this issue
14 tasks
@kaz462 kaz462 closed this as completed in #45 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

5 participants