Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuration file not found - suggestion for improved documentation #140

Open
marianklose opened this issue Apr 29, 2023 · 1 comment
Open

Comments

@marianklose
Copy link

Hi everyone,

thanks for your great work! Not sure if this is the right way how to suggest some future improvement in documentation. After setting up pharmpy and pharmr I tried to run a dummy example:

load_example_model('pheno') %>% fit()

Exception: "FileNotFoundError('No path to NONMEM configured in pharmpy.conf and nmfe not in PATH')"

Based on the docs in https://pharmpy.github.io/latest/configuration.html I tried to locate the config file.

get_config_path()

Cannot find config path C:\Users\Admin\AppData\Local\Pharmpy\Pharmpy\pharmpy.conf
warnings.warn(f'Cannot find config path {config_path}')

According to the pharmpy docs ('It is possible to create an empty template configuration file using the create_default_config function.') there should be a function create_default_config which creates the config file in case it doesn't exist yet. In R however this function is named slightly different but I couldn't find a hint to that fact.

create_default_config()

Error in create_default_config() :
could not find function "create_default_config"

With the command create_config_template() it worked and I was able to run the dummy example.

create_config_template()

NULL

get_config_path()

[1] "C:\Users\Admin\AppData\Local\Pharmpy\Pharmpy\pharmpy.conf"

I would suggest to either name the function in the pharmr environment also create_default_config() or to add a small hint in https://pharmpy.github.io/latest/configuration.html that the function in R is named create_config_template(). For me that would've helped. Thank you!

@rikardn
Copy link
Contributor

rikardn commented May 2, 2023

Thanks for the valuable feedback! We will try to make this clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants