Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Voyage-mongo-tests] VOMongoTest class >> #isAbstract strange implementation #158

Closed
CafeKrem opened this issue May 29, 2020 · 2 comments · Fixed by #160
Closed

[Voyage-mongo-tests] VOMongoTest class >> #isAbstract strange implementation #158

CafeKrem opened this issue May 29, 2020 · 2 comments · Fixed by #160

Comments

@CafeKrem
Copy link
Contributor

I found something strange in VOMongoTest

isAbstract
	^ super isAbstract or: [ self name = #VOMongoTest ]

why we check if his superclass is abstract ? We only need to check if to test if self is abstract and only him.
@noha
Copy link
Collaborator

noha commented Jun 2, 2020

Looks strange to me, too. Can you provide a PR?

@CafeKrem
Copy link
Contributor Author

CafeKrem commented Jun 2, 2020

yes

@CafeKrem CafeKrem mentioned this issue Jun 2, 2020
Merged
@noha noha closed this as completed in #160 Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

158-Voyage-mongo-tests-VOMongoTest-class--isAbstract-strange-implementation
2 participants
@noha @CafeKrem