Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FFI call of Variadiac Arguments Function is not working in Apple ARM #350

Closed
tesonep opened this issue Dec 2, 2021 · 0 comments · Fixed by pharo-project/pharo#11421
Closed

FFI call of Variadiac Arguments Function is not working in Apple ARM #350

tesonep opened this issue Dec 2, 2021 · 0 comments · Fixed by pharo-project/pharo#11421

Comments

@tesonep
Copy link
Collaborator

tesonep commented Dec 2, 2021

The calling convention is not the same as that in regular ARM (SysV).
It looks like LibFFI handles it, but seems there is a bug. We need to debug it and propose a fix.

Once fixed we need to un-skip the following Pharo tests.

All Failed Tests

  • MacOSX64.ThreadedFFI.Tests.TFFunctionCallTest.testVariadicFunctionWithOneFixedAndTwoOptional(#runner->[ TFSameThreadRunner uniqueInstance ])
  • MacOSX64.UnifiedFFI.Tests.Tests.FFICalloutAPITest.testCallWithAllConstParameter
  • MacOSX64.UnifiedFFI.Tests.Tests.FFICalloutAPITest.testCallWithConstParameter
  • MacOSX64.UnifiedFFI.Tests.Tests.FFIExternalEnumerationTest.testCall
  • MacOSX64.UnifiedFFI.Tests.Tests.FFIExternalEnumerationTest.testReturn
tesonep added a commit to tesonep/pharo that referenced this issue Dec 2, 2021
@tesonep
Skipping some tests that are not working in Apple ARM because an issu…
f942d04 
…e in the VM (pharo-project/pharo-vm#350)
hogoww added a commit to hogoww/opensmalltalk-vm that referenced this issue Dec 23, 2021
@hogoww
Mutant pharo-project#350, Installing [ Replace #ifTrue: receiver with…
9bc0c5d 
… true ] on method [ allocateOldSpaceChunkOfBytes: ]
hogoww added a commit to hogoww/opensmalltalk-vm that referenced this issue Dec 23, 2021
@hogoww
Mutant pharo-project#350, Reverting [ Replace #ifTrue: receiver with …
2bd28f7 
…true ] on method [ allocateOldSpaceChunkOfBytes: ] KILLED by 2/168 test cases.
hogoww added a commit to hogoww/opensmalltalk-vm that referenced this issue Dec 29, 2021
@hogoww
Mutant pharo-project#350, Installing [ Replace #and: argument with [t…
6303b06 
…rue] ] on method [ classAtIndex: ]
hogoww added a commit to hogoww/opensmalltalk-vm that referenced this issue Dec 29, 2021
@hogoww
Mutant pharo-project#350, Reverting [ Replace #and: argument with [tr…
4157bfd 
…ue] ] on method [ classAtIndex: ] KILLED by 1/30 test cases.
hogoww added a commit to hogoww/opensmalltalk-vm that referenced this issue Feb 26, 2022
@hogoww
Mutant pharo-project#350, Installing [ Remove ^ ] on method [ followO…
18cbd50 
…bjField:ofObject: ] 3 test cases.
hogoww added a commit to hogoww/opensmalltalk-vm that referenced this issue Feb 26, 2022
@hogoww
Mutant pharo-project#350, Reverting [ Remove ^ ] on method [ followOb…
a132947 
…jField:ofObject: ] 3/3 Test Cases are NOT EQUIVALENT
MarcusDenker added a commit to MarcusDenker/pharo that referenced this issue Jun 29, 2022
@MarcusDenker
This PR fixes pharo-project/pharo-vm#350
8cc13fa 
There where some FFI tests skiped on the M1, but they are alerady working (all green here after removing the #skipOnAppleARM)
@MarcusDenker MarcusDenker mentioned this issue Jun 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup-M1-Variadic-FFI-Tests MarcusDenker/pharo
1 participant
@tesonep