-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Save As" does not create an image that is launchable #53
Comments
This is already reported in #18 |
There are now 2 ways to run an image created with "Save As" :
Is it enough to solve this issue? |
@apblack Can we close the issue? |
I think that you have done everything reasonable as maintainers of the launcher. But I don't think that the issue s solved for the programmer who is using the launcher. What would solve it would be a variation on "Save As .." in the main menu that will offer to create a "launcher compatible" folder containing the newly-saved image. This would mean that the standard image would have to be able to detect that it was run from the launcher — perhaps by looking to see if the image file is inside a directory of the same name. So, perhaps the right thing to do is to close this issue, and open one in FogBugz, since this will have to be solved in Pharo itself. |
I agree with @apblack : the issue is not yet solved but it will be difficult to implement it. The hard point is indeed: how an image could be aware that it has been launched from the launcher? And yes, that means that we should introduce code in the image => new problem: this code can only be introduced into the development version of Pharo and not past releases. It means this functionality could only work starting Pharo 7. |
It is the same kind of problem as my image saver. A solution would be to have a command listing all images in the folder and offer to open one. |
To amplify what @philippeback said: a solution that could be implemented in the launcher itself would be for the launcher to notice when there is more than one pair of .image & .changes files in the directory that it is about to launch, and to ask the user of the launcher to pick one pair from a list. I think that the right solution is to introduce new functionality into Pharo 7's "Save As …" command, so that, going forward, this ceases to be a problem. And this is an ideal time to do so, because Pharo 7 is under active development. But, as @demarey points out, this cannot solve the problem for older versions of Pharo. Having the launcher offer a list would solve the problem for such systems. |
Is it not possible to launch sub images with an additional command line argument ? |
@svenvc yes, I think it would be a good idea to use an extra command-line argument. That said, it will still require new code to manage that in the standard Pharo image. But that will solve the problem for Pharo images >= 7.0 |
I'm a relatively new person to Pharo (less than 3 years, and much of it was in Pharo 5 with a minimal understanding, so I'm really still quite a newbie). Currently (because of this issue), I don't use Pharo Launcher except when I'm starting with a new image. In my workflow (on Windows 10), I just run Pharo.exe (from the VM) and select the latest image (done with Save as...) for my project. Windows 10's file system does a great job finding it. Why am I doing "Save as..." with images and not just "Save"? Here are a few reasons:
|
As for solutions, I'm a Windows 10 person lately (please forgive me for that), so I know there's a way to have a right-click option in Windows Explorer to say "Open with..." on a file of type |
If I do a "Save As..." from an existing image (that has been launched form the launcher), new image and changes files are created in the existing launcher folder. But this image cannot be launched from the launcher.
This is because the name of the image does not correspond to the name of the folder.
The text was updated successfully, but these errors were encountered: