-
Notifications
You must be signed in to change notification settings - Fork 67
/
MLLocalizationTestCase.class.st
888 lines (691 loc) · 30.1 KB
/
MLLocalizationTestCase.class.st
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
Class {
#name : #MLLocalizationTestCase,
#superclass : #TestCase,
#instVars : [
'ccg'
],
#category : #Melchor
}
{ #category : #running }
MLLocalizationTestCase >> applyLocalizationTo: interpreterSelector [
| interpretMethod |
ccg addClass: MockLocalizationInterpreterMock.
ccg prepareMethods.
ccg inlineDispatchesInMethodNamed: interpreterSelector.
ccg doBasicInlining: true.
SLAutomaticLocalization new
codeGenerator: ccg;
applyMethodNamed: interpreterSelector.
interpretMethod := ccg methodNamed: interpreterSelector.
ccg currentMethod: interpretMethod.
^ interpretMethod
]
{ #category : #running }
MLLocalizationTestCase >> applyLocalizationToInterpretWith: initializationSelector [
"Prepare methods will replace the bytecode dispatch instruction into a dispatch switch"
MockLocalizationInterpreterMock perform: initializationSelector.
^ self applyLocalizationTo: #interpret
]
{ #category : #running }
MLLocalizationTestCase >> applyManyLocalizationsToInterpretWith: initializationSelector [
"Prepare methods will replace the bytecode dispatch instruction into a dispatch switch"
MockLocalizationInterpreterMock perform: initializationSelector.
^ self applyLocalizationTo: #interpretWithSeveralVariablesToLocalize
]
{ #category : #helpers }
MLLocalizationTestCase >> assert: aTStatementListNode isRewrittenAs: aString [
self assert: (aTStatementListNode isSameAs: (self tastFor: aString))
]
{ #category : #running }
MLLocalizationTestCase >> externalizationOf: aVariableName [
^ (TAssignmentNode
variableNamed: aVariableName
expression: (TVariableNode named: #local_, aVariableName))
]
{ #category : #running }
MLLocalizationTestCase >> internalizationOf: aVariableName [
^ (TAssignmentNode
variableNamed: #local_, aVariableName
expression: (TVariableNode named: aVariableName))
]
{ #category : #helpers }
MLLocalizationTestCase >> linearise: aMethod [
| methodToLinearize |
ccg vmmakerConfiguration bytesPerWord: 8.
ccg vmmakerConfiguration bytesPerOop: 8.
ccg addClass: aMethod methodClass.
methodToLinearize := ccg methodNamed: aMethod selector.
ccg prepareMethods.
ccg currentMethod: methodToLinearize.
SLAutomaticLocalization new
codeGenerator: ccg;
linearizeExternalCallsIn: methodToLinearize
withVariableBindings: ((ccg initAutoLocalizationOfVariablesIn: #interpret) asDictionary
collect: [:n| TVariableNode named: n]).
^ methodToLinearize
]
{ #category : #helpers }
MLLocalizationTestCase >> linearizedBlockOfCaseMethod: aTMethod [
| case inlinedMethod |
case := (aTMethod detect: [ :e | e isCaseStmt ]) cases first.
inlinedMethod := (case detect: [ :e | e isInline ]) method.
^ inlinedMethod parseTree
]
{ #category : #running }
MLLocalizationTestCase >> setUp [
super setUp.
ccg := MLVMCCodeGenerator new.
ccg vmMaker: VMMaker new.
ccg vmMaker vmmakerConfiguration: VMMakerConfiguration.
MockLocalizationInterpreterMock initialize
]
{ #category : #helpers }
MLLocalizationTestCase >> tastFor: someCode [
"Parse the expression as a method with a single expression.
Transform it to TAST and get the first statement of the TMethod.
Expected: the first statement of the TMethod should correspond to the first statement of the RMethod"
^ ((RBParser parseExpression: someCode) methodNode
compilationContext: CompilationContext new;
asTranslationMethodOfClass: TMethod)
parseTree
]
{ #category : #'tests - initialization' }
MLLocalizationTestCase >> testAutoLocalizeVariableDefinesNewLocalVariable [
"Prepare methods will replace the bytecode dispatch instruction into a dispatch switch"
ccg addClass: MockLocalizationInterpreterMock.
ccg initAutoLocalizationOfVariablesIn: #interpret.
self assert: ((ccg methodNamed: #interpret) locals includes: #local_autoLocalizedVariable)
]
{ #category : #'tests - initialization' }
MLLocalizationTestCase >> testAutoLocalizeVariableDefinesNewLocalVariableWhenNameConflict [
"Prepare methods will replace the bytecode dispatch instruction into a dispatch switch"
ccg addClass: MockLocalizationInterpreterMock.
ccg initAutoLocalizationOfVariablesIn: #interpretWithLocalizedVariableConflict.
self assert: ((ccg methodNamed: #interpretWithLocalizedVariableConflict) locals includes: #local_autoLocalizedVariable1)
]
{ #category : #'tests - initialization' }
MLLocalizationTestCase >> testAutoLocalizeVariableDefinesNewLocalVariables [
"Prepare methods will replace the bytecode dispatch instruction into a dispatch switch"
| method |
ccg addClass: MockLocalizationInterpreterMock.
ccg initAutoLocalizationOfVariablesIn: #interpretWithSeveralVariablesToLocalize.
method := (ccg methodNamed: #interpretWithSeveralVariablesToLocalize).
self assert: ( method locals includes: #local_autoLocalizedVariable1).
self assert: (method locals includes: #local_autoLocalizedVariable)
]
{ #category : #'tests - localisation' }
MLLocalizationTestCase >> testAutoLocalizeVariableDoesNotLineariseUnnecessaryStatements [
"Prepare methods will replace the bytecode dispatch instruction into a dispatch switch"
| interpretMethod printedString block |
interpretMethod := self applyLocalizationToInterpretWith: #initializeWithoutAutoLocalizedVariable.
block := self linearizedBlockOfCaseMethod: interpretMethod.
printedString := String streamContents: [ :str | (block asCASTIn: ccg) prettyPrintOn: str ].
self assert: printedString equals: '{
nonInlinedMethodNotUsingAutolocalizedVariables(nonInlinedMethodNotUsingAutolocalizedVariables());
}'
]
{ #category : #'tests - localisation' }
MLLocalizationTestCase >> testAutoLocalizeVariableExternalizesAtTheEnd [
| externalizationStatement interpretMethod |
interpretMethod := self applyLocalizationTo: #interpret.
externalizationStatement := interpretMethod statements last first.
self assert: (externalizationStatement isSameAs:
(self externalizationOf: #autoLocalizedVariable))
]
{ #category : #'tests - localisation' }
MLLocalizationTestCase >> testAutoLocalizeVariableExternalizesBeforeReturnReferenchingAutoLocalizedVariable [
"Prepare methods will replace the bytecode dispatch instruction into a dispatch switch"
| interpretMethod printedString |
interpretMethod := self applyLocalizationTo: #interpretWithReturnExpressionUpdatingAutoLocalizedVariable.
printedString := String streamContents: [ :str |
((TStatementListNode statements: (interpretMethod statements last: 2)) asCASTIn: ccg)
prettyPrintOn: str ].
self assert: printedString equals: '{
local_autoLocalizedVariable += 1;
{
autoLocalizedVariable = local_autoLocalizedVariable;
autoLocalizedVariable1 = local_autoLocalizedVariable1;
return local_autoLocalizedVariable;
}
}'
]
{ #category : #'tests - localisation' }
MLLocalizationTestCase >> testAutoLocalizeVariableExternalizesBeforeReturns [
"Prepare methods will replace the bytecode dispatch instruction into a dispatch switch"
| interpretMethod sendNode |
interpretMethod := self applyLocalizationTo: #interpretWithReturnExpression.
sendNode := interpretMethod last.
self assert: sendNode arguments first last last isReturn.
self
assert: (sendNode arguments first last first
isSameAs: (self externalizationOf: #autoLocalizedVariable)).
self assert: sendNode arguments second last last isReturn.
self
assert: (sendNode arguments second last first
isSameAs: (self externalizationOf: #autoLocalizedVariable))
]
{ #category : #'tests - localisation' }
MLLocalizationTestCase >> testAutoLocalizeVariableInternalizesAtTheBeginning [
| internalizationStatement interpretMethod |
interpretMethod := self applyLocalizationTo: #interpret.
internalizationStatement := interpretMethod statements first.
self
assert: (internalizationStatement isSameAs: (self internalizationOf: #autoLocalizedVariable))
]
{ #category : #'tests - localisation' }
MLLocalizationTestCase >> testAutoLocalizeVariableReplacesByLocalOnInline [
"Prepare methods will replace the bytecode dispatch instruction into a dispatch switch"
| interpretMethod variableNode case |
interpretMethod := self applyLocalizationToInterpretWith: #initializeWithAutoLocalizedVariableOnly.
"Fail if we find some node inside the case that uses the localized variable"
case := (interpretMethod detect: [:e | e isCaseStmt ]) cases first.
variableNode := (case detect: [ :e | e isAssignment ]) variable.
self assert: (variableNode isVariable and: [ variableNode name = #local_autoLocalizedVariable ]).
]
{ #category : #'tests - free variables' }
MLLocalizationTestCase >> testCollectFreeVariablesOfMethodWithManyCallers [
| collector |
collector := SLCallGraphFreeVariableCollector codeGenerator: ccg.
ccg addClass: MockLocalizationInterpreterMock.
ccg prepareMethods.
"
variableToLocalize should be considered free in the entire transitive call graph.
/-- methodCallingBytecodeUsingLocalizedVariable --\
/ \
methodWithDiamond < >--> bytecodeUsingLocalizedVariable (using variable variableToLocalize)
\ /
\-- methodCallingBytecodeUsingLocalizedVariable2 --/
"
collector startFromSelector: #methodWithDiamond.
self assert: ((collector freeVariablesUsedByMethodNamed: #bytecodeUsingLocalizedVariable) includes: #variableToLocalize).
self assert: ((collector freeVariablesUsedByMethodNamed: #methodCallingBytecodeUsingLocalizedVariable) includes: #variableToLocalize).
self assert: ((collector freeVariablesUsedByMethodNamed: #methodCallingBytecodeUsingLocalizedVariable2) includes: #variableToLocalize).
self assert: ((collector freeVariablesUsedByMethodNamed: #methodWithDiamond) includes: #variableToLocalize).
]
{ #category : #'tests - localisation' }
MLLocalizationTestCase >> testExternalEscapingAsArgument [
| interpretMethod cast printedString linearizedBlock |
interpretMethod := self applyLocalizationToInterpretWith: #initializeWithEscapingCallAsArgument.
"Assert that the send node is preceded by variable externalization"
linearizedBlock := self linearizedBlockOfCaseMethod: interpretMethod.
cast := linearizedBlock asCASTIn: ccg.
printedString := String streamContents: [ :str | cast prettyPrintOn: str ].
self assert: printedString equals:
'{
sqInt t0;
{
autoLocalizedVariable = local_autoLocalizedVariable;
t0 = foo2();
local_autoLocalizedVariable = autoLocalizedVariable;
}
if (1 == t0) {
}
}'
]
{ #category : #'tests - localisation' }
MLLocalizationTestCase >> testExternalEscapingAsArgumentOfExternalCall [
| interpretMethod cast printedString linearizedBlock |
interpretMethod := self applyManyLocalizationsToInterpretWith: #initializeWithEscapingCallAsArgumentOfExternalCall.
"Assert that the send node is preceded by variable externalization"
linearizedBlock := self linearizedBlockOfCaseMethod: interpretMethod.
cast := linearizedBlock asCASTIn: ccg.
printedString := String streamContents: [ :str | cast prettyPrintOn: str ].
self assert: printedString equals: '{
sqInt t0;
{
autoLocalizedVariable1 = local_autoLocalizedVariable1;
t0 = nonInlinedMethodUsingAutolocalizedVariable1();
local_autoLocalizedVariable1 = autoLocalizedVariable1;
}
{
autoLocalizedVariable = local_autoLocalizedVariable;
autoLocalizedVariable1 = local_autoLocalizedVariable1;
autoLocalizedVariable2 = local_autoLocalizedVariable2;
foo(t0);
local_autoLocalizedVariable = autoLocalizedVariable;
local_autoLocalizedVariable1 = autoLocalizedVariable1;
local_autoLocalizedVariable2 = autoLocalizedVariable2;
}
}'.
]
{ #category : #'tests - localisation' }
MLLocalizationTestCase >> testExternalEscapingSendNodeInInlinedMethod [
| interpretMethod cast printedString linearizedBlock |
interpretMethod := self applyManyLocalizationsToInterpretWith: #initializeWithInlinedMethodCall.
"Assert that the send node is preceded by variable externalization"
linearizedBlock := self linearizedBlockOfCaseMethod: interpretMethod.
cast := linearizedBlock second asCASTIn: ccg.
printedString := String streamContents: [ :str | cast prettyPrintOn: str ].
self assert: printedString equals: '{
autoLocalizedVariable = local_autoLocalizedVariable;
autoLocalizedVariable1 = local_autoLocalizedVariable1;
foo2();
local_autoLocalizedVariable = autoLocalizedVariable;
local_autoLocalizedVariable1 = autoLocalizedVariable1;
}'
]
{ #category : #'tests - localisation' }
MLLocalizationTestCase >> testExternalEscapingSendNodeShouldBeTranslatedWithExternalizationAndInternalization [
| interpretMethod cast printedString linearizedBlock |
interpretMethod := self applyLocalizationToInterpretWith: #initializeWithEscapingCall.
"Assert that the send node is preceded by variable externalization"
linearizedBlock := self linearizedBlockOfCaseMethod: interpretMethod.
cast := linearizedBlock asCASTIn: ccg.
printedString := String streamContents: [ :str | cast prettyPrintOn: str ].
self assert: printedString equals: '{
local_autoLocalizedVariable += 1;
{
autoLocalizedVariable = local_autoLocalizedVariable;
foo(local_autoLocalizedVariable);
local_autoLocalizedVariable = autoLocalizedVariable;
}
}'
]
{ #category : #'tests - localisation' }
MLLocalizationTestCase >> testExternalEscapingStatementInConditionalBody [
| interpretMethod cast printedString linearizedBlock |
interpretMethod := self applyLocalizationToInterpretWith: #initializeWithIfStatement.
"Assert that the send node is preceded by variable externalization"
linearizedBlock := self linearizedBlockOfCaseMethod: interpretMethod.
cast := linearizedBlock asCASTIn: ccg.
printedString := String streamContents: [ :str | cast prettyPrintOn: str ].
"The if statement should not be wrapped. Only the inner statements"
self assert: printedString equals:
'{
if (1) {
sqInt t0;
{
autoLocalizedVariable = local_autoLocalizedVariable;
t0 = nonInlinedMethodUsingAutolocalizedVariable();
local_autoLocalizedVariable = autoLocalizedVariable;
}
{
autoLocalizedVariable = local_autoLocalizedVariable;
foo(t0);
local_autoLocalizedVariable = autoLocalizedVariable;
}
}
}'
]
{ #category : #'tests - localisation' }
MLLocalizationTestCase >> testExternalPerform [
| interpretMethod cast printedString linearizedBlock |
interpretMethod := self applyLocalizationToInterpretWith: #initializeWithPerform.
"Assert that the send node is preceded by variable externalization"
linearizedBlock := self linearizedBlockOfCaseMethod: interpretMethod.
cast := linearizedBlock asCASTIn: ccg.
printedString := String streamContents: [ :str | cast prettyPrintOn: str ].
self assert: printedString equals:
'{
{
autoLocalizedVariable = local_autoLocalizedVariable;
foo();
local_autoLocalizedVariable = autoLocalizedVariable;
}
}'
]
{ #category : #'tests - localisation' }
MLLocalizationTestCase >> testExternalSendNodeExternalizeAndInternalizeOnlyNeededVariables [
| interpretMethod cast printedString linearizedBlock |
interpretMethod := self applyManyLocalizationsToInterpretWith: #initializeWithEscapingCall.
"Assert that the send node is preceded by variable externalization"
linearizedBlock := self linearizedBlockOfCaseMethod: interpretMethod.
cast := linearizedBlock asCASTIn: ccg.
printedString := String streamContents: [ :str | cast prettyPrintOn: str ].
self assert: printedString equals: '{
local_autoLocalizedVariable += 1;
{
autoLocalizedVariable = local_autoLocalizedVariable;
autoLocalizedVariable1 = local_autoLocalizedVariable1;
autoLocalizedVariable2 = local_autoLocalizedVariable2;
foo(local_autoLocalizedVariable);
local_autoLocalizedVariable = autoLocalizedVariable;
local_autoLocalizedVariable1 = autoLocalizedVariable1;
local_autoLocalizedVariable2 = autoLocalizedVariable2;
}
}'
]
{ #category : #'tests - localisation' }
MLLocalizationTestCase >> testExternalSendNodeShouldBeTranslatedWithExternalizationAndInternalization [
| interpretMethod cast printedString linearizedBlock |
interpretMethod := self
applyLocalizationToInterpretWith: #initializeWithExternalizedAutoLocalizedVariableInExpressionOnly.
"Assert that the send node is preceded by variable externalization"
linearizedBlock := self linearizedBlockOfCaseMethod: interpretMethod.
cast := linearizedBlock asCASTIn: ccg.
printedString := String streamContents: [ :str | cast prettyPrintOn: str ].
self assert: printedString equals: '{
sqInt t0;
{
autoLocalizedVariable = local_autoLocalizedVariable;
t0 = nonInlinedMethodUsingAutolocalizedVariable();
local_autoLocalizedVariable = autoLocalizedVariable;
}
{
autoLocalizedVariable = local_autoLocalizedVariable;
foo(t0);
local_autoLocalizedVariable = autoLocalizedVariable;
}
}'
]
{ #category : #'tests - linearization' }
MLLocalizationTestCase >> testLinearizeAndInsideValueIf [
| methodToLinearize replacementBlock |
methodToLinearize := self linearise:
MockLocalizationInterpreterMock >> #bytecodeUsingNestedConditionalValueWithAnd.
"Before it was
^ overflow := self condition
ifTrue: [ self condition ]
ifFalse: [ self condition and: [ self condition ] ]"
replacementBlock := methodToLinearize parseTree.
"We have an extra nested code because the linearisation algorithm does not flatten..."
self assert: replacementBlock isRewrittenAs: '
self condition
ifTrue: [ t0 := self condition ]
ifFalse: [
t0 := self condition.
t0
ifTrue: [ t0 := self condition ]
ifFalse: [ t0 := t0 ] ].
overflow := t0.
^ overflow'.
]
{ #category : #'tests - linearization' }
MLLocalizationTestCase >> testLinearizeAndInsideValueIfNestedTwice [
| methodToLinearize replacementBlock |
methodToLinearize := self linearise:
MockLocalizationInterpreterMock >> #bytecodeUsingTwiceNestedConditionalValueWithAnd.
"Before it was
^ overflow := self condition
ifTrue: [ self condition ]
ifFalse: [
self condition
ifTrue: [ self condition ]
ifFalse: [ self condition and: [ self condition ] ] ]"
replacementBlock := methodToLinearize parseTree.
"We have an extra nested code because the linearisation algorithm does not flatten..."
self assert: replacementBlock isRewrittenAs: '
self condition
ifTrue: [ t0 := self condition ]
ifFalse: [
self condition
ifTrue: [ t0 := self condition ]
ifFalse: [
t0 := self condition.
t0
ifTrue: [ t0 := self condition ]
ifFalse: [ t0 := t0 ] ] ].
overflow := t0.
^ overflow'.
]
{ #category : #'tests - linearization' }
MLLocalizationTestCase >> testLinearizeCallsInNestedLexicalScope [
| methodToLinearize ifBlock expected |
methodToLinearize := self linearise:
MockLocalizationInterpreterMock >> #bytecodeUsingExternalizedAutoLocalizedVariableInNestedLexicalScope.
"Before it was
true ifTrue: [
self foo: self nonInlinedMethodUsingAutolocalizedVariable
]
After
true ifTrue: [
| t0 |
t0 := self nonInlinedMethodUsingAutolocalizedVariable.
self foo: t0
] "
ifBlock := methodToLinearize statements first arguments first.
expected := self tastFor: '[| t0 |
t0 := self nonInlinedMethodUsingAutolocalizedVariable.
self foo: t0]'.
self assert: (ifBlock isSameAs: expected first)
]
{ #category : #'tests - linearization' }
MLLocalizationTestCase >> testLinearizeComplexAssert [
| methodToLinearize replacementBlock |
methodToLinearize := self linearise:
MockLocalizationInterpreterMock >> #bytecodeUsingComplexAssert.
"Before it was
self assert: (self foo or: [ self bar and: [ self fum ] ])"
replacementBlock := methodToLinearize parseTree.
"We have an extra nested code because the linearisation algorithm does not flatten..."
self assert: replacementBlock isRewrittenAs: '
self assert: (self foo or: [ self bar and: [ self fum ] ])'.
]
{ #category : #'tests - linearization' }
MLLocalizationTestCase >> testLinearizeNestedCalls [
| methodToLinearize replacementBlock expected |
methodToLinearize := self linearise:
MockLocalizationInterpreterMock >> #bytecodeUsingExternalizedAutoLocalizedVariableAsExpression.
"Before it was
self foo: self nonInlinedMethodUsingAutolocalizedVariable.
After
t0 := self nonInlinedMethodUsingAutolocalizedVariable.
self foo: t0"
replacementBlock := methodToLinearize parseTree.
expected := self tastFor: '| t0 |
t0 := self nonInlinedMethodUsingAutolocalizedVariable.
self foo: t0'.
self assert: (replacementBlock isSameAs: expected)
]
{ #category : #'tests - initialization' }
MLLocalizationTestCase >> testLinearizeNestedCallsWithAssignment [
| methodToLinearize replacementBlock |
ccg addClass: MockLocalizationInterpreterMock.
methodToLinearize := ccg methodNamed: #bytecodeUsingExternalizedAutoLocalizedVariableAsExpressionInAssignment.
ccg prepareMethods.
ccg currentMethod: methodToLinearize.
SLAutomaticLocalization new
codeGenerator: ccg;
linearizeExternalCallsIn: methodToLinearize
withVariableBindings: ((ccg initAutoLocalizationOfVariablesIn: #interpret) asDictionary
collect: [:n| TVariableNode named: n]).
"Before it was
foo := self foo: self nonInlinedMethodUsingAutolocalizedVariable.
After
t0 := self nonInlinedMethodUsingAutolocalizedVariable.
t1 := self foo: t0.
foo := t1"
replacementBlock := methodToLinearize parseTree.
self assert: (replacementBlock statements first
isSameAs: (TAssignmentNode
variableNamed: 't0'
expression: (TSendNode
receiver: TVariableNode selfNode
selector: #nonInlinedMethodUsingAutolocalizedVariable))).
self assert: (replacementBlock statements second
isSameAs: (TAssignmentNode
variableNamed: 't1'
expression: (TSendNode
receiver: TVariableNode selfNode
selector: #foo:
arguments: { TVariableNode named: 't0' }))).
self assert: (replacementBlock statements third
isSameAs: (TAssignmentNode
variableNamed: 'foo'
expression: (TVariableNode named: 't1')))
]
{ #category : #'tests - linearization' }
MLLocalizationTestCase >> testLinearizeNestedCallsWithReturn [
| methodToLinearize replacementBlock expected |
methodToLinearize := self linearise:
MockLocalizationInterpreterMock >> #bytecodeUsingExternalizedAutoLocalizedVariableAsExpressionInReturn.
"Before it was
^ self foo: self nonInlinedMethodUsingAutolocalizedVariable.
After
t0 := self nonInlinedMethodUsingAutolocalizedVariable.
t1 := self foo: t0.
^ t1"
replacementBlock := methodToLinearize parseTree.
expected := self tastFor: '| t0 t1 |
t0 := self nonInlinedMethodUsingAutolocalizedVariable.
t1 := self foo: t0.
^ t1'.
self assert: (replacementBlock isSameAs: expected)
]
{ #category : #'tests - linearization' }
MLLocalizationTestCase >> testLinearizeReceiverOfConditional [
| methodToLinearize replacementBlock expected |
methodToLinearize := self linearise:
MockLocalizationInterpreterMock >> #bytecodeUsingExternalizedAutoLocalizedVariableAsIfReceiver.
"Before it was
self nonInlinedMethodUsingAutolocalizedVariable ifTrue: [].
After
t0 := self nonInlinedMethodUsingAutolocalizedVariable.
t0 ifTrue: []"
replacementBlock := methodToLinearize parseTree.
expected := self tastFor: '| t0 t1 |
t0 := self nonInlinedMethodUsingAutolocalizedVariable.
t0 ifTrue: [ nil ]'.
self assert: (replacementBlock isSameAs: expected)
]
{ #category : #'tests - linearization' }
MLLocalizationTestCase >> testLinearizeReceiverOfConditionalAnd [
| methodToLinearize replacementBlock |
methodToLinearize := self linearise:
MockLocalizationInterpreterMock >> #bytecodeUsingExternalizedAutoLocalizedVariableAsIfReceiverWithAnd.
"Before it was
(self nonInlinedMethodUsingAutolocalizedVariable and: [
self nonInlinedMethodUsingAutolocalizedVariable ]) ifTrue: [ ]"
replacementBlock := methodToLinearize parseTree.
"We have an extra nested code because the linearisation algorithm does not flatten..."
self assert: replacementBlock isRewrittenAs: '
t0 := self nonInlinedMethodUsingAutolocalizedVariable.
t0 ifTrue: [ t1 := self nonInlinedMethodUsingAutolocalizedVariable ] ifFalse: [ t1 := t0 ].
t1 ifTrue: [nil]'.
]
{ #category : #'tests - linearization' }
MLLocalizationTestCase >> testLinearizeReceiverOfConditionalAndAssigned [
| methodToLinearize replacementBlock |
methodToLinearize := self linearise:
MockLocalizationInterpreterMock >> #bytecodeUsingExternalizedAutoLocalizedVariableAsAssignmentWithAnd.
"Before it was
var := self nonInlinedMethodUsingAutolocalizedVariable and: [
self nonInlinedMethodUsingAutolocalizedVariable ].
var ifTrue: [ ]"
replacementBlock := methodToLinearize parseTree.
"We have an extra nested code because the linearisation algorithm does not flatten..."
self assert: replacementBlock isRewrittenAs: '
t0 := self nonInlinedMethodUsingAutolocalizedVariable.
t0 ifTrue: [ t1 := self nonInlinedMethodUsingAutolocalizedVariable ] ifFalse: [ t1 := t0 ].
var := t1.
var ifTrue: [nil]'.
]
{ #category : #'tests - linearization' }
MLLocalizationTestCase >> testLinearizeReceiverOfConditionalNestedAnd [
| methodToLinearize replacementBlock |
methodToLinearize := self linearise:
MockLocalizationInterpreterMock >> #bytecodeUsingExternalizedAutoLocalizedVariableAsIfReceiverWithNestedAnd.
"Before it was
(self nonInlinedMethodUsingAutolocalizedVariable and: [
self foo and: [ self bar ] ]) ifTrue: [ ]"
replacementBlock := methodToLinearize parseTree.
"We have an extra nested code because the linearisation algorithm does not flatten..."
self assert: replacementBlock isRewrittenAs: '
t0 := self nonInlinedMethodUsingAutolocalizedVariable.
t0 ifTrue: [ | t0 |
t0 := self foo.
t0
ifTrue: [ t1 := self bar ]
ifFalse: [ t1 := t0 ]]
ifFalse: [ t1 := t0 ].
t1 ifTrue: [nil]'.
]
{ #category : #'tests - linearization' }
MLLocalizationTestCase >> testLinearizeReceiverOfConditionalOr [
| methodToLinearize replacementBlock |
methodToLinearize := self linearise:
MockLocalizationInterpreterMock >> #bytecodeUsingExternalizedAutoLocalizedVariableAsIfReceiverWithOr.
"Before it was
(self nonInlinedMethodUsingAutolocalizedVariable or: [
self nonInlinedMethodUsingAutolocalizedVariable ]) ifTrue: [ ]"
replacementBlock := methodToLinearize parseTree.
"We have an extra nested code because the linearisation algorithm does not flatten..."
self assert: replacementBlock isRewrittenAs: '
t0 := self nonInlinedMethodUsingAutolocalizedVariable.
t0 ifTrue: [ t1 := t0 ] ifFalse: [ t1 := self nonInlinedMethodUsingAutolocalizedVariable ].
t1 ifTrue: [ nil ]'.
]
{ #category : #'tests - linearization' }
MLLocalizationTestCase >> testLinearizeReceiverOfNestedConditional [
| methodToLinearize replacementBlock |
methodToLinearize := self linearise:
MockLocalizationInterpreterMock >> #bytecodeUsingExternalizedAutoLocalizedVariableAsIfReceiverWithNestedConditional.
"Before it was
(self nonInlinedMethodUsingAutolocalizedVariable ifTrue: [
self nonInlinedMethodUsingAutolocalizedVariable ])
ifTrue: [ ]
After
t0 := self nonInlinedMethodUsingAutolocalizedVariable.
t0 ifTrue: [t1 := self nonInlinedMethodUsingAutolocalizedVariable] ifFalse: [t1 := t0].
t1 ifTrue: []"
replacementBlock := methodToLinearize parseTree.
"We have an extra nested code because the linearisation algorithm does not flatten..."
self assert: replacementBlock isRewrittenAs: '
t0 := self nonInlinedMethodUsingAutolocalizedVariable.
t0 ifTrue: [t1 := self nonInlinedMethodUsingAutolocalizedVariable] ifFalse: [t1 := t0].
t1 ifTrue: [nil]'.
]
{ #category : #'tests - linearization' }
MLLocalizationTestCase >> testLinearizeSingleCalls [
| methodToLinearize replacementBlock |
methodToLinearize := self linearise:
MockLocalizationInterpreterMock >> #bytecodeUsingInlinedCall.
"Before it was
self inlinedMethodUsingExternalCall.
After
self inlinedMethodUsingExternalCall"
replacementBlock := methodToLinearize parseTree.
self assert: replacementBlock isRewrittenAs: 'self inlinedMethodUsingExternalCall'
]
{ #category : #'tests - old localization' }
MLLocalizationTestCase >> testLocalizeSharedVariableShouldFail [
"Prepare methods will replace the bytecode dispatch instruction into a dispatch switch"
ccg addClass: MockLocalizationInterpreterMock.
ccg prepareMethods.
[ ccg localizeVariables: #( sharedVariableToLocalize ) inMethod: (ccg methodNamed: #interpret).
"This should not arrive here"
self fail
] on: Error do: [ :error |
self assert: error messageText equals: 'Cannot localize Shared Variables in the interpreter loop: sharedVariableToLocalize' ].
]
{ #category : #'tests - old localization' }
MLLocalizationTestCase >> testLocalizeSharedVariableShouldFailIfAllInlinedUsesAreNotInlined [
"Prepare methods will replace the bytecode dispatch instruction into a dispatch switch"
ccg addClass: MockLocalizationInterpreterMock.
ccg retainMethods: #( interpret ).
ccg prepareMethods.
ccg inlineDispatchesInMethodNamed: #interpret.
ccg pruneUnreachableMethods.
self assert: (ccg methodNamed: #methodAlsoSharedLocalizedVariableBeforeInlining) notNil.
"This should not fail"
[
ccg localizeVariables: #( sharedVariableToLocalizeBeforeInlining ) inMethod: (ccg methodNamed: #interpret).
"This should not arrive here"
self fail
] on: Error do: [ :error |
self assert: error messageText equals: 'Cannot localize Shared Variables in the interpreter loop: sharedVariableToLocalizeBeforeInlining' ]
]
{ #category : #'tests - old localization' }
MLLocalizationTestCase >> testLocalizeSharedVariableShouldNotFailIfAllUsesAreInlined [
"Prepare methods will replace the bytecode dispatch instruction into a dispatch switch"
ccg addClass: MockLocalizationInterpreterMock.
ccg retainMethods: #( interpret ).
ccg prepareMethods.
ccg doBasicInlining: true.
ccg inlineDispatchesInMethodNamed: #interpret.
ccg pruneUnreachableMethods.
"This should not fail"
ccg localizeVariables: #( sharedVariableToLocalizeBeforeInlining ) inMethod: (ccg methodNamed: #interpret)
]
{ #category : #'tests - localisation' }
MLLocalizationTestCase >> testNoExternalSendNodeOnSafeExternalCall [
| interpretMethod cast printedString linearizedBlock |
interpretMethod := self applyManyLocalizationsToInterpretWith: #initializeWithSafeEscapingCall.
"Assert that the send node is preceded by variable externalization"
linearizedBlock := self linearizedBlockOfCaseMethod: interpretMethod.
cast := linearizedBlock asCASTIn: ccg.
printedString := String streamContents: [ :str | cast prettyPrintOn: str ].
self assert: printedString equals: '{
nonInlinedMethodNotUsingAutolocalizedVariables((local_autoLocalizedVariable += 1));
}'
]