/
RBPullUpMethodTest.class.st
209 lines (195 loc) · 7.47 KB
/
RBPullUpMethodTest.class.st
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
Class {
#name : #RBPullUpMethodTest,
#superclass : #RBRefactoringTest,
#category : #'Refactoring-Tests-Core-Refactorings'
}
{ #category : #tests }
RBPullUpMethodTest >> addClassHierarchy [
model
defineClass: 'Object subclass: #SomeClass instanceVariableNames: '''' classVariableNames: ''Foo'' poolDictionaries: '''' category: #''Refactory-Test data'''.
model
defineClass: 'SomeClass subclass: #Subclass instanceVariableNames: '''' classVariableNames: '''' poolDictionaries: '''' category: #''Refactory-Test data'''.
model
defineClass: 'Subclass subclass: #Foo1 instanceVariableNames: '''' classVariableNames: '''' poolDictionaries: '''' category: #''Refactory-Test data'''.
model
defineClass: 'Subclass subclass: #Foo2 instanceVariableNames: '''' classVariableNames: '''' poolDictionaries: '''' category: #''Refactory-Test data'''.
]
{ #category : #tests }
RBPullUpMethodTest >> addClassHierarchyForPools [
model
defineClass: 'SharedPool subclass: #TotoSharedPool instanceVariableNames: '''' classVariableNames: ''SP'' poolDictionaries: '''' category: #''Refactory-Test data'''.
model
defineClass: 'Object subclass: #TotoSuperclass instanceVariableNames: '''' classVariableNames: '''' poolDictionaries: '''' category: #''Refactory-Test data'''.
model
defineClass: 'TotoSuperclass subclass: #Toto instanceVariableNames: '''' classVariableNames: '''' poolDictionaries: '''' category: #''Refactory-Test data'''.
(model classNamed: #Toto) compile: 'poolReference ^ SP' classified: #(#accessing).
]
{ #category : #tests }
RBPullUpMethodTest >> testPullUpAndCopyDown [
| class |
self addClassHierarchy.
class := model classNamed: #Foo1.
class compile: 'yourself ^1' classified: #(#accessing).
self proceedThroughWarning: [ self executeRefactoring: (RBPullUpMethodRefactoring
model: model
pullUp: #(#yourself)
from: class) ].
self assert: (class superclass parseTreeFor: #yourself)
equals: (self parseMethod: 'yourself ^1').
self deny: (class directlyDefinesMethod: #yourself).
class := model classNamed: #Foo2.
self assert: (class directlyDefinesMethod: #yourself).
self assert: (class parseTreeFor: #yourself)
equals: ((model classNamed: #Object) parseTreeFor: #yourself)
]
{ #category : #'failure tests' }
RBPullUpMethodTest >> testPullUpClassMethod [
| class |
class := model classNamed: #Object.
class addClassVariable: #Foo.
class classSide
compile: 'foo ^Foo'
classified: #(#accessing ).
self shouldFail: (RBPullUpMethodRefactoring
model: model
pullUp: #(#foo )
from: class classSide)
]
{ #category : #tests }
RBPullUpMethodTest >> testPullUpInAHighHierarchyClass [
| class superClass |
self addClassHierarchy .
class := model classNamed: #Foo1.
self addClassHierarchy.
superClass := model classNamed: #SomeClass .
class compile: 'example ^1' classified: #(#accessing).
self executeRefactoring: (RBPullUpMethodRefactoring
model: model
pullUp: #(#example)
from: class
to: superClass ).
self assert: (superClass parseTreeFor: #example)
equals: (self parseMethod: 'example ^1').
self deny: (class directlyDefinesMethod: #example).
class := model classNamed: #Subclass.
self assert: (class definesMethod: #example).
self assert: (class parseTreeFor: #example)
equals: ((model classNamed: #SomeClass) parseTreeFor: #example)
]
{ #category : #tests }
RBPullUpMethodTest >> testPullUpMethodWithCopyOverriddenMethodsDown [
| refactoring |
self proceedThroughWarning:
[ refactoring := RBPullUpMethodRefactoring
pullUp: #(#isComposite )
from: RBCompositeLintRuleTestData.
self executeRefactoring: refactoring ].
self assert: ((refactoring model classNamed: #RBBasicLintRuleTestData) parseTreeFor: #isComposite) equals: (self parseMethod: 'isComposite ^false').
self assert: ((refactoring model classNamed: ('RBFoo' , 'LintRuleTestData') asSymbol) parseTreeFor: #isComposite) equals: (self parseMethod: 'isComposite ^false').
self assert: ((refactoring model classNamed: #RBLintRuleTestData) parseTreeFor: #isComposite) equals: (self parseMethod: 'isComposite ^true').
self deny: ((refactoring model classNamed: #RBCompositeLintRuleTestData) directlyDefinesMethod: #isComposite)
]
{ #category : #tests }
RBPullUpMethodTest >> testPullUpMethodWithSharedPool [
| class superClass |
self addClassHierarchyForPools.
class := model classNamed: #Toto.
superClass := model classNamed: #TotoSuperclass.
self executeRefactoring: (RBPullUpMethodRefactoring
model: model
pullUp: #(#poolReference)
from: class
to: superClass ).
self assert: (superClass parseTreeFor: #poolReference)
equals: (self parseMethod: 'poolReference ^ SP').
self deny: (class directlyDefinesMethod: #poolReference).
]
{ #category : #'failure tests' }
RBPullUpMethodTest >> testPullUpReferencesInstVar [
self shouldFail: (RBPullUpMethodRefactoring
pullUp: #(#checkClass: )
from: RBBasicLintRuleTestData)
]
{ #category : #'failure tests' }
RBPullUpMethodTest >> testPullUpWhenSuperClassDoesNotDirectlyImplement [
| classEnvironment classes |
classes := #(#ClassA #ClassB #ClassC)
inject: OrderedCollection new
into: [ :sum :each |
testingEnvironment
at: each
ifPresent: [ :class |
sum
add: class;
add: class class ].
sum ].
classEnvironment := RBClassEnvironment classes: classes.
model name: 'Test'.
"Classes"
#('Object subclass: #ClassA
instanceVariableNames: ''''
classVariableNames: ''''
poolDictionaries: ''''
category: ''Testing'' ' 'ClassA subclass: #ClassB
instanceVariableNames: ''''
classVariableNames: ''''
poolDictionaries: ''''
category: ''Testing'' ' 'ClassB subclass: #ClassC
instanceVariableNames: ''''
classVariableNames: ''''
poolDictionaries: ''''
category: ''Testing'' ') do: [ :each | model defineClass: each ].
#(#(#ClassA #(#('foo
^ ''ClassA foo''' #private))) #(#ClassC #(#('foo
^ ''ClassC foo''' #private))))
do: [ :each |
| class |
class := model classNamed: each first.
each last
do:
[ :methodPair | class compile: methodPair first classified: methodPair last ] ].
self
shouldntWarn:
(RBPullUpMethodRefactoring
model: model
pullUp: #(#foo)
from: (model classNamed: #ClassC))
]
{ #category : #'failure tests' }
RBPullUpMethodTest >> testPullUpWithInvalidSuperSend [
| class |
self addClassHierarchy .
(model classNamed: #Foo2) compile: 'yourself ^super yourself + 1'
classified: #(#accessing).
class := model classNamed: #Foo1.
class compile: 'yourself ^1' classified: #(#accessing).
self shouldFail: (RBPullUpMethodRefactoring
model: model
pullUp: #(#yourself)
from: class)
]
{ #category : #'failure tests' }
RBPullUpMethodTest >> testPullUpWithMethodThatCannotBePullUp [
model
defineClass: 'Object subclass: #SomeClass instanceVariableNames: '''' classVariableNames: ''Foo'' poolDictionaries: '''' category: #''Refactory-Test data'''.
(model classNamed: #SomeClass) compile: 'yourself ^54'
classified: #(#accessing).
self shouldFail: (RBPullUpMethodRefactoring
model: model
pullUp: #(#yourself)
from: (model classNamed: #SomeClass))
]
{ #category : #'failure tests' }
RBPullUpMethodTest >> testPullUpWithSuperSendThatCannotBeCopiedDown [
| class |
self addClassHierarchy.
(model classNamed: #Object) compile: 'foo ^3' classified: #(#accessing).
(model classNamed: #Subclass) compile: 'foo ^super foo'
classified: #(#accessing).
(class := model classNamed: #Foo2) compile: 'foo ^1'
classified: #(#accessing).
self shouldFail: (RBPullUpMethodRefactoring
model: model
pullUp: #(#foo)
from: class)
]