Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Memory] Every class and meta class has both a ProtocolOrganizer and a ClassOrganization #10959

Closed
MarcusDenker opened this issue Feb 28, 2022 · 0 comments · Fixed by #13187
Closed

[Memory] Every class and meta class has both a ProtocolOrganizer and a ClassOrganization #10959

MarcusDenker opened this issue Feb 28, 2022 · 0 comments · Fixed by #13187
Labels
Type: Cleanup

Comments

@MarcusDenker
Copy link
Member

Describe the problem
For every class, we have 2 ProtocolOrganizer and 2 ClassOrganization instances. This wastes memory

Why is that a problem?
For one, it wastes memory. But in addition, it adds not-needed complexity.

Proposal
There are two steps:

  • merge ProtocolOrganizer and ClassOrganization classes. There should be only ProtocolOrganizer
  • after this is done, we should review and ask if we really need the -Organizer? In the end, protocols are just a collection of protocols. Why do we even need an organizer for that?
@MarcusDenker MarcusDenker changed the title Every class and meta class has both a ProtocolOrganizer and a ClassOrganization [Memory] Every class and meta class has both a ProtocolOrganizer and a ClassOrganization Feb 28, 2022
@MarcusDenker MarcusDenker linked a pull request Apr 1, 2023 that will close this issue
Inline protocol organizer #13187
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Inline protocol organizer jecisc/pharo
1 participant
@MarcusDenker