Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] testGmailEncrypted timeout #12917

Closed
MarcusDenker opened this issue Mar 7, 2023 · 7 comments
Closed

[CI] testGmailEncrypted timeout #12917

MarcusDenker opened this issue Mar 7, 2023 · 7 comments
Milestone

Comments

@MarcusDenker
Copy link
Member

Bug description
testGmailEncrypted times out often

@MarcusDenker
Copy link
Member Author

There is ZnHttpsTest and ZnHttpsTests, one has the timeout, one not

Solution: unify the two

@svenvc
Copy link
Contributor

svenvc commented Mar 7, 2023

The plural one, ZnHttpsTests is from the Zinc repository:

https://github.com/svenvc/zinc/tree/master/repository/Zinc-Zodiac-Tests.package/ZnHTTPSTests.class

From my point of view, ZnHttpsTests can be removed.

GitHub
Zinc HTTP Components is an open-source Smalltalk framework to deal with the HTTP networking protocol. - zinc/repository/Zinc-Zodiac-Tests.package/ZnHTTPSTests.class at master · svenvc/zinc

@MarcusDenker
Copy link
Member Author

In Pharo11, there is just ZnHTTPSTest (no s) and it has no timeout.

So maybe the sync did not work correctly?

@svenvc
Copy link
Contributor

svenvc commented Mar 7, 2023

Ah OK, hmm, I saw this is my work pharo 11 image from some time ago, where we were doing the integration.

BTW, they are in different packages also:

  • ZnHttpsTests is in Zinc-Zodiac-Tests
  • ZnHttosTest is in Zinc-Zodiac

That last package does not exist in my Zinc repository.

@MarcusDenker MarcusDenker added this to the 11.0.0 milestone Mar 7, 2023
@jecisc
Copy link
Member

jecisc commented Mar 7, 2023

The problem is that in Pharo we have the package Zinc-Zodiac and in Zinc we have Zinc-Zodiac-Core and Zinc-Zodiac-Tests

So Iceberg was not able to find the diffs during the last sync since the packages are different.

I'll try to check was is the equivalent of what was integrated before and sync the name changes

@MarcusDenker
Copy link
Member Author

Still happening

@MarcusDenker
Copy link
Member Author

ah, no, PR was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants