Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ReCodeCruftLeftInMethodsRule: take #haltOrBreakpointForTesting into account #14250

Open
MarcusDenker opened this issue Jul 10, 2023 · 1 comment

Comments

@MarcusDenker
Copy link
Member

We have methods that send #halt, but they are not a problem as they are tagged with #haltOrBreakpointForTesting or #debuggerCompleteToSender

The rule ReCodeCruftLeftInMethodsRule should take that into account

@jecisc
Copy link
Member

jecisc commented Apr 18, 2024

Recently, added on rules checking all nodes of a method a guard to be able to skip whole methods.

The original plan was to speed up the checking of those methods in some cases. But this can be use in this case!

The guard is done by overriding ReAbstractRule>>#shouldCheckMethod:. Maybe ReCodeCruftLeftInMethodsRule could override it to check the pragmas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants