Iceberg: not able to browse tags / missing implementation of #branchName

[astares]

• In Iceberg click to a connected repo (like the Pharo repo)
• select "Open Repository"

then try to open a tag and you will get a DNU

[astares]

IceTipTagModel(Object)>>doesNotUnderstand: #branchName
IceTipCachedModel>>forwardMessage:
IceTipCachedModel>>doesNotUnderstand: #branchName
Message>>sendTo:
IceTipTreeTag(IceTipTreeNode)>>doesNotUnderstand: #branchName
IceTipResetBranchToThisCommitCommand>>defaultNameFromContext
IceTipResetBranchToThisCommitCommand>>name
IceTipSpCommand(CmCommandDecorator)>>name
CmCommandGroup>>ensureNotDuplicated:
CmCommandGroup>>registerLast:
CmCommandGroup>>register:
SpCommandGroup(CmCommandGroupDecorator)>>register:
[ :each |
aCommandGroup register: (each forSpecContext: presenter) ] in IceTipHiedraHistoryBrowser class(IceTipHistoryBrowser class)>>buildSelectionCommandGroupWith:for: in Block: [ :each |...
Array(SequenceableCollection)>>do:
IceTipHiedraHistoryBrowser class(IceTipHistoryBrowser class)>>buildSelectionCommandGroupWith:for:
IceTipHiedraHistoryBrowser class(IceTipBrowser class)>>buildCommandsGroupWith:forRoot:
IceTipHiedraHistoryBrowser class(SpPresenter class)>>buildRootCommandsGroupFor:
IceTipHiedraHistoryBrowser(SpPresenter)>>rootCommandsGroup
IceTipHiedraHistoryBrowser(IceTipBrowser)>>refreshCommands
[ self refreshCommands ] in IceTipHiedraHistoryBrowser(IceTipBrowser)>>connectPresenters in Block: [ self refreshCommands ]
FullBlockClosure(BlockClosure)>>cull:
[ aBlock cull: self ] in SpSingleSelectionMode>>whenChangedDo: in Block: [ aBlock cull: self ]
FullBlockClosure(BlockClosure)>>cull:
FullBlockClosure(BlockClosure)>>cull:cull:
[ :block | block cull: self value cull: oldValue ] in ObservableValueHolder>>valueChanged: in Block: [ :block | block cull: self value cull: oldValue ]
OrderedCollection>>do:
ObservableValueHolder>>valueChanged:
[ | oldValue |
oldValue := value.
value := anObject.
self valueChanged: oldValue ] in ObservableValueHolder>>value: in Block: [ | oldValue |...
FullBlockClosure(BlockClosure)>>ensure:
ObservableValueHolder>>value:
SpSingleSelectionMode>>basicSelectIndex:
SpSingleSelectionMode(SpAbstractSelectionMode)>>selectIndex:
SpSingleSelectionMode>>unselectAll
SpTablePresenter(SpAbstractListPresenter)>>unselectAll
SpTablePresenter(SpAbstractListPresenter)>>items:
IceTipHiedraHistoryBrowser(IceTipHistoryBrowser)>>refreshCommitList
IceTipHiedraHistoryBrowser(IceTipHistoryBrowser)>>refresh
IceTipHiedraHistoryBrowser>>refresh
IceTipHiedraHistoryBrowser(IceTipHistoryBrowser)>>model:
IceTipRepositoryBrowser>>commitishSelected:
[ :selection |
(selection isEmpty not and: [ selection selectedItem isCommitish ])
ifTrue: [ self commitishSelected: selection selectedItem ] ] in IceTipRepositoryBrowser>>initializeSidebarTree in Block: [ :selection | ...
FullBlockClosure(BlockClosure)>>cull:
[ aBlock cull: selectionMode ] in SpTreeTablePresenter(SpAbstractTreePresenter)>>whenSelectionChangedDo: in Block: [ aBlock cull: selectionMode ]
FullBlockClosure(BlockClosure)>>cull:
FullBlockClosure(BlockClosure)>>cull:cull:
[ :block | block cull: self value cull: oldValue ] in ObservableValueHolder>>valueChanged: in Block: [ :block | block cull: self value cull: oldValue ]
OrderedCollection>>do:
ObservableValueHolder>>valueChanged:
[ | oldValue |
oldValue := value.
value := anObject.
self valueChanged: oldValue ] in ObservableValueHolder>>value: in Block: [ | oldValue |...
FullBlockClosure(BlockClosure)>>ensure:
ObservableValueHolder>>value:
SpTreeSingleSelectionMode>>selectPath:
SpTreeSingleSelectionMode>>selectPaths:
SpMorphicTreeTableAdapter>>basicSelectionChanged:
[
self basicSelectionChanged: ann ] in SpMorphicTreeTableAdapter>>selectionChanged: in Block: [ ...
FullBlockClosure(BlockClosure)>>ensure:
SpMorphicTreeTableAdapter>>suspendSelectionEventsDuring:
SpMorphicTreeTableAdapter>>selectionChanged:
MessageSend>>value:
MessageSend>>cull:
MessageSend>>cull:cull:
[ action cull: anAnnouncement cull: announcer ] in AnnouncementSubscription(AbstractAnnouncementSubscription)>>deliver: in Block: [ action cull: anAnnouncement cull: announcer ]
FullBlockClosure(BlockClosure)>>on:do:
[ Processor terminateRealActive ] in [ :ex |
| onDoCtx handler bottom thisCtx |
onDoCtx := thisContext.
thisCtx := onDoCtx home.

		  "find the context on stack for which this method's is sender"

		  [ onDoCtx sender == thisCtx ] whileFalse: [
			  onDoCtx := onDoCtx sender.
			  onDoCtx ifNil: [ "Can't find our home context. seems like we're already forked
			and handling another exception in new thread. In this case, just pass it through handler."
				  ^ handlerAction cull: ex ] ].

		  bottom := [ Processor terminateRealActive ] asContext.
		  onDoCtx privSender: bottom.

		  handler := [ handlerAction cull: ex ] asContext.
		  handler privSender: thisContext sender.

		  (Process forContext: handler priority: Processor activePriority) resume.

		  "cut the stack of current process"
		  thisContext privSender: thisCtx.
		  nil ] in FullBlockClosure(BlockClosure)>>on:fork: in Block: [ Processor terminateRealActive ]

[astares]

Maybe in class IceTipResetBranchToThisCommitCommand the method

defaultNameFromContext

	| shortId branchName |
	shortId := self selectedCommitish ifNotNil: [ :commitish | commitish shortId ] ifNil: [''].
	branchName := self selectedBranch ifNotNil: [:branch | branch branchName] ifNil: [ '' ].

	^ 'Reset ', branchName, ' to commit ', shortId

should be changed to

defaultNameFromContext

	| shortId branchName |
	shortId := self selectedCommitish ifNotNil: [ :commitish | commitish shortId ] ifNil: [''].
	branchName := self selectedBranch ifNotNil: [:branch | branch name] ifNil: [ '' ].

	^ 'Reset ', branchName, ' to commit ', shortId

to solve it.

[Ducasse]

This is strange because I do not get the error. Just that the tag is not created.