Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting implementations exist for #extractAllIn: for ZipArchive #16238

Open
Rinzwind opened this issue Feb 23, 2024 · 5 comments
Open

Conflicting implementations exist for #extractAllIn: for ZipArchive #16238

Rinzwind opened this issue Feb 23, 2024 · 5 comments
Assignees

Comments

@Rinzwind
Copy link
Contributor

There are conflicting implementations for #extractAllIn: for ZipArchive in the ‘pharo’ and ‘NewTools’ repositories. This leads to confusion when committing as only of the two implementations can be loaded in the image and the one in the other repository is unexpectedly shown in the commit window as being removed.

@Rinzwind
Copy link
Contributor Author

Other conflicting implementations: #settingsOn: for NECPreferences in ‘pharo’ and ‘NewTools’, #possibleSolutionsForInput: on MethodFinder in ‘pharo’ and ‘NewTools’.

@hernanmd
Copy link
Contributor

I don't know why extractAllIn: is still in Pharo repo, it should be in NewTools-Compression-Utils (pharo-spec/NewTools@ef9aad0)
I will make a PR to remove it from Pharo.

@hernanmd hernanmd self-assigned this Feb 27, 2024
@astares
Copy link
Member

astares commented Feb 27, 2024

@hernanmd Shouldnt it be the other way around: have it by default already in standard Pharo and remove the extension in NewTools.

Because it is usuable in a wider scope to deal with ZIPs (also in smaller images that just have ZIP but not NewTools)

@hernanmd
Copy link
Contributor

@hernanmd Shouldnt it be the other way around: have it by default already in standard Pharo and remove the extension in NewTools.

Because it is usuable in a wider scope to deal with ZIPs (also in smaller images that just have ZIP but not NewTools)

This was already discussed in the context of removing UIManager references, because this method was using UI.

@astares
Copy link
Member

astares commented Feb 27, 2024

Answering to myself: ok - it opens a dialog (StOpenDirectoryPresenter) to ask for the target folder. So yes - it should be part of NewTools only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants