Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The StRewriterRuleEditor helpfully shows sample rules, there is no way for projects to easily add their example rules #16753

Closed
macta opened this issue Jun 4, 2024 · 6 comments

Comments

@macta
Copy link
Contributor

macta commented Jun 4, 2024

Describe the request
The StRewriterDemoRules class (which is badly named - and should be called StRewriterSampleRules or StRewriterTemplateRules) has a list of useful rules which are accessible from the Rewriter Rule Editor tool. However if you want to add your own rules to the list for people to use, there is no easy way to extend this without editing the class.

Expected behavior
Ypou should be able to add a rule extension method - and its a quick fix to make this tool use a pragma to fine such sample rules - I suggest

Expected development cost
trivial

Screenshots
image

Version information:

  • OS: [e.g. iOS]
  • Version: [e.g. 1.6.1]
  • Pharo Version P13

Additional context
I have a proposed fix

@macta
Copy link
Contributor Author

macta commented Jun 5, 2024

@jecisc where is the NewTools repo - as I've realised that this browser is in NewTools and don't know what repo to clone to propose a fix?

@jecisc
Copy link
Member

jecisc commented Jun 5, 2024

Hi Tim,
The NewTools repository is in the pharo-spec association.

https://github.com/pharo-spec/NewTools

GitHub
All development tools for Pharo, developed with Spec - pharo-spec/NewTools

@macta
Copy link
Contributor Author

macta commented Jun 5, 2024

How would you feel about renaming StRewriterDemoRules to StRewriterTemplateRules, as they are more than demo rules, there are some great ones in there and potentially other libraries could add to them ? Could do it in the PR I plan to submit or propose a new one.

@macta
Copy link
Contributor Author

macta commented Jun 5, 2024

Not quite sure how PR's for that other repo are handled - but the PR has been submitted over there in pharo-spec/NewTools#770

@macta
Copy link
Contributor Author

macta commented Jun 5, 2024

Do I need to create a seperate issue in that Repo?

@jordanmontt
Copy link
Member

Solved in pharo-spec/NewTools#770

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants