-
-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The StRewriterRuleEditor helpfully shows sample rules, there is no way for projects to easily add their example rules #16753
Comments
@jecisc where is the NewTools repo - as I've realised that this browser is in NewTools and don't know what repo to clone to propose a fix? |
Hi Tim, https://github.com/pharo-spec/NewTools
|
How would you feel about renaming StRewriterDemoRules to StRewriterTemplateRules, as they are more than demo rules, there are some great ones in there and potentially other libraries could add to them ? Could do it in the PR I plan to submit or propose a new one. |
Not quite sure how PR's for that other repo are handled - but the PR has been submitted over there in pharo-spec/NewTools#770 |
Do I need to create a seperate issue in that Repo? |
Solved in pharo-spec/NewTools#770 |
Describe the request
The StRewriterDemoRules class (which is badly named - and should be called StRewriterSampleRules or StRewriterTemplateRules) has a list of useful rules which are accessible from the Rewriter Rule Editor tool. However if you want to add your own rules to the list for people to use, there is no easy way to extend this without editing the class.
Expected behavior
Ypou should be able to add a rule extension method - and its a quick fix to make this tool use a pragma to fine such sample rules - I suggest
Expected development cost
trivial
Screenshots
![image](https://private-user-images.githubusercontent.com/5553623/336622578-62716944-d162-4e67-9cc3-96c830c6517c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIzMTc1MzEsIm5iZiI6MTcyMjMxNzIzMSwicGF0aCI6Ii81NTUzNjIzLzMzNjYyMjU3OC02MjcxNjk0NC1kMTYyLTRlNjctOWNjMy05NmM4MzBjNjUxN2MucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDczMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MzBUMDUyNzExWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NmVmZTMwYWIyNjJhMTFlOGRkNjA3MGNiZDJhZDJjMjRiMjI1YmZhNzFlNTY3MTU5OWFmYzI2NzM0ZTNmMThlMiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ._1bOSfTpldcEd-_2bUzMaSKM_XHj04P3mbR92tym_9Y)
Version information:
Additional context
I have a proposed fix
The text was updated successfully, but these errors were encountered: