Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic of changeFactory references is suspicious #3173

Ducasse opened this Issue Apr 11, 2019 · 0 comments


None yet
1 participant
Copy link

commented Apr 11, 2019

RefactoryChangeFactory class >> instance
^ RBRefactoryChangeManager instance changeFactory

RefactoringChangeManager class >> instance
^ Instance ifNil: [ Instance := self basicNew initialize ]

RefactoringChangeManager >> changeFactory
^ RBRefactoryChangeFactory new

I do not see the point to pass via the singleton if this is just to return a fresh instance each time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.