Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic of changeFactory references is suspicious #3173

Closed
Ducasse opened this issue Apr 11, 2019 · 9 comments
Closed

Logic of changeFactory references is suspicious #3173

Ducasse opened this issue Apr 11, 2019 · 9 comments

Comments

@Ducasse
Copy link
Member

Ducasse commented Apr 11, 2019

RefactoryChangeFactory class >> instance
^ RBRefactoryChangeManager instance changeFactory

RefactoringChangeManager class >> instance
^ Instance ifNil: [ Instance := self basicNew initialize ]

RefactoringChangeManager >> changeFactory
^ RBRefactoryChangeFactory new

I do not see the point to pass via the singleton if this is just to return a fresh instance each time.

@stale
Copy link

stale bot commented Oct 8, 2019

To limit bug bankruptcy (see https://www.joelonsoftware.com/2012/07/09/software-inventory/) this issue has been automatically marked as stale because it has not had any activity in 6 months. It will be closed in 1 month if no further activity occurs. If this issue remains important to you, please comment to reactivate the issue. Thank you for your contributions.

Joel on Software
Imagine, for a moment, that you came upon a bread factory for the first time. At first it just looks like a jumble of incomprehensible machinery with a few people buzzing around. As your eyes adjus…

@stale stale bot added the stale label Oct 8, 2019
@Ducasse
Copy link
Member Author

Ducasse commented Oct 9, 2019

I do not like the stale robot can we remove it.!

@stale stale bot removed the stale label Oct 9, 2019
@noha
Copy link
Member

noha commented Oct 9, 2019

Why? Do you want to keep all issues that nobody cares about? Sure these mails are annoying but they help clean stuff and concentrate on things somebody cares, no?

@Ducasse
Copy link
Member Author

Ducasse commented Oct 9, 2019

Because I have to write on the issues that I want to work on!!!

@noha
Copy link
Member

noha commented Oct 9, 2019

You mean issues you want to work on but didn‘t in the last months?

@Ducasse
Copy link
Member Author

Ducasse commented Oct 9, 2019

Exactly and seriously I'm not the only one to be annoyed by this stale robot. Marcus changed the delay.

@noha
Copy link
Member

noha commented Oct 9, 2019

I‘m not a fan of the stale robit and won‘t defend it. I‘m just asking myself if in a couple of month from now there is moaning about the very growing issue list where too many issues are okd and nobody cares. What is the alternative for this ?

@Ducasse
Copy link
Member Author

Ducasse commented Oct 9, 2019

Tagging and encouraging people to contribute.

@guillep
Copy link
Member

guillep commented Jan 27, 2023

This issue looks more like a small project than an actionable issue.
I propose we move it to a wiki with potential projects for people to contribute.
Could be a great basis for GSOC.

@guillep guillep closed this as completed Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants