Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harvesting Nicolas's speedup #3322

Closed
Ducasse opened this issue May 9, 2019 · 5 comments
Closed

Harvesting Nicolas's speedup #3322

Ducasse opened this issue May 9, 2019 · 5 comments

Comments

@Ducasse
Copy link
Member

Ducasse commented May 9, 2019

http://smallissimo.blogspot.com/2019/05/accelerating-large-integer-arithmetic.html

@SergeStinckwich
Copy link
Contributor

SergeStinckwich commented Jul 24, 2019

I start to have a look to this. As mentionned by @nicolas-cellier-aka-nice on his blog, I propose to do it in two commits:

  • add Integer>>multiplyByInteger: and Integer>>divideByInteger: hooks so that subclasses can redefine their own. Redefine Integer>>*, Integer>>quo: and Integer>>/ to use these hooks.
  • Modify/add users of the previous methods for LargeInteger (LargePositiveInteger in Squeak), add methods digitMul22:, digitMul23:, digitMul33:, digitDiv21:, digitDiv32:, digitDivSplit:,digitMulSplit:, inplaceAddNonOverlapping:digitShiftBy:, squaredByFourth, sqrtRem, squaredByHalf, squaredByThird and squaredByFourth. Add tests.

@nicolas-cellier-aka-nice any comments ?

@SergeStinckwich
Copy link
Contributor

SergeStinckwich commented Aug 4, 2019

@Ducasse Any comments ?

@Ducasse
Copy link
Member Author

Ducasse commented Aug 4, 2019

For me I'm bad with number so go ahead and write some bench to see the gain.

@stale
Copy link

stale bot commented Apr 10, 2020

To limit bug bankruptcy (see https://www.joelonsoftware.com/2012/07/09/software-inventory/) this issue has been automatically marked as stale because it has not had any activity in 6 months. If no further activity occurs, it might be closed. If this issue remains important to you, please comment to reactivate the issue. Thank you for your contributions.

Joel on Software
Imagine, for a moment, that you came upon a bread factory for the first time. At first it just looks like a jumble of incomprehensible machinery with a few people buzzing around. As your eyes adjus…

@stale stale bot added the stale label Apr 10, 2020
@guillep
Copy link
Member

guillep commented Jan 27, 2023

This issue looks more like a small project than an actionable issue.
I propose we move it to a wiki with potential projects for people to contribute.
I'm collecting all these.
Could be a great basis for GSOC.

@guillep guillep closed this as completed Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants