Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instVarNames is not including instance variables coming from Stateful traits #4149

Closed
gcotelli opened this issue Jul 29, 2019 · 3 comments
Closed

Comments

@gcotelli
Copy link
Member

For example, TextPresenter is using TSpecHaveWrappingScrollBars that includes a wrapScrollBars slot, but
TextPresenter superclass instSize >> 40
TextPresenter instSize >> 42 "Seems to be considered here, but:"
TextPresenter instVarNames -> #(#scrollValue)

This is breaking Fuel serialization because ClassDescritpion>>instanceVariableNamesDo: uses instSize to iterate over the variables returned by instVarName, so you get a SubscriptOutOfBounds error.

@gcotelli gcotelli changed the title instVarNames is not including instance variables coming from Stateful traits instVarNames is not including instance variables coming from Stateful traits Jul 29, 2019
@jecisc
Copy link
Member

jecisc commented Jul 29, 2019

Seems linked to #3546 and #3520

@MarcusDenker
Copy link
Member

I adde a PR that we might consider: #4367

The idea is that #instVarnames should return #slots, not #localSlots.

@MarcusDenker
Copy link
Member

This is now fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants